Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Session manager] Sessions without encryption support should not prompt to verify #7733

Closed
mnaturel opened this issue Dec 7, 2022 · 0 comments · Fixed by #7736
Closed

[Session manager] Sessions without encryption support should not prompt to verify #7733

mnaturel opened this issue Dec 7, 2022 · 0 comments · Fixed by #7736
Assignees
Labels
A-Settings T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@mnaturel
Copy link
Contributor

mnaturel commented Dec 7, 2022

Steps to reproduce

When a session did not upload its crypto keys, the UI in session manager screens is not correct. It displays a "Verify" button which is not possible for this session.
UI should be updated to inform the user the session cannot be verified.

Outcome

What did you expect?

Not to be able to verify sessions without encryption keys. Also, the app should not alert of unverified sessions which do not support encryption.

What happened instead?

"Verify" action is available for sessions without encryption keys.

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

No

Are you willing to provide a PR?

Yes

@mnaturel mnaturel added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A-Settings labels Dec 7, 2022
@mnaturel mnaturel self-assigned this Dec 7, 2022
@RiotRobot RiotRobot added this to Incoming in Issue triage Dec 7, 2022
@mnaturel mnaturel moved this from Incoming to Triaged in Issue triage Dec 7, 2022
Issue triage automation moved this from Triaged to Closed Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Settings T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
No open projects
1 participant