Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Session manager] Other sessions: Filter bottom sheet cut in landscape mode #7786

Closed
mnaturel opened this issue Dec 15, 2022 · 0 comments · Fixed by #7791
Closed

[Session manager] Other sessions: Filter bottom sheet cut in landscape mode #7786

mnaturel opened this issue Dec 15, 2022 · 0 comments · Fixed by #7791
Assignees
@mnaturel
Labels
A-Settings O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
Issue triage

Comments

@mnaturel
Copy link
Contributor

Steps to reproduce

Use a small phone to reproduce

  • Enable the new session manager labs setting
  • Go to Settings -> Security & Privacy -> Show all sessions
  • Press the View all button in the other sessions section (need more than 5 other sessions)
  • Put the phone in landscape mode
  • Press the filter option in the top app bar

Outcome

What did you expect?

All the bottom sheet content should be viewable.

What happened instead?

The content for the "Other sessions" filter bottom sheet don't scroll, which causes the contents to be cut off on the bottom.

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

No

Are you willing to provide a PR?

Yes
@mnaturel mnaturel added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems S-Minor Impairs non-critical functionality or suitable workarounds exist O-Uncommon Most users are unlikely to come across this or unexpected workflow A-Settings labels Dec 15, 2022
@mnaturel mnaturel self-assigned this Dec 15, 2022
@RiotRobot RiotRobot added this to Incoming in Issue triage Dec 15, 2022
@mnaturel mnaturel mentioned this issue Dec 15, 2022
Merged
15 tasks
@mnaturel mnaturel moved this from Incoming to Triaged in Issue triage Dec 15, 2022
Issue triage automation moved this from Triaged to Closed Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnaturel mnaturel

Labels
A-Settings O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
No open projects
Issue triage
Closed
Milestone
No milestone
1 participant
@mnaturel