Automatically show keyboard after learn more bottom sheet is dismissed (PSG-1105) #7790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onurays
requested review from
a team and
mnaturel
and removed request for
a team
onurays
changed the title
This reverts commit f0dc6e4.
onurays
changed the title
mnaturel
reviewed
Dec 16, 2022
| SessionLearnMoreBottomSheet.show(childFragmentManager, args) | ||
| SessionLearnMoreBottomSheet | ||
| .show(childFragmentManager, args) | ||
| .apply { |
There was a problem hiding this comment.
I think in general in the project, we try to avoid using apply to avoid bugs on the scope of objects. Maybe it will be better to write it this way:
SessionLearnMoreBottomSheet
.show(childFragmentManager, args)
.onDismiss = { showKeyboard() }
mnaturel
reviewed
Dec 16, 2022
| views.renameSessionEditText.doOnTextChanged { text, _, _, _ -> | ||
| viewModel.handle(RenameSessionAction.EditLocally(text.toString())) | ||
| } | ||
| } | ||
|
|
||
| private fun showKeyboard() { |
There was a problem hiding this comment.
Suggested change
| private fun showKeyboard() { | |
| private fun showKeyboard() { | |
| val focusChangeListener = object : ViewTreeObserver.OnWindowFocusChangeListener { | |
| override fun onWindowFocusChanged(hasFocus: Boolean) { | |
| if (hasFocus) { | |
| views.renameSessionEditText.showKeyboard(andRequestFocus = true) | |
| } | |
| views.renameSessionEditText.viewTreeObserver.removeOnWindowFocusChangeListener(this) | |
| } | |
| } | |
| views.renameSessionEditText.viewTreeObserver.addOnWindowFocusChangeListener(focusChangeListener) | |
| } |
There was a problem hiding this comment.
I think we should remove the listener once done (see my suggestion above). Otherwise it will keep adding a listener each time and every listeners will be called.
mnaturel
suggested changes
Dec 16, 2022
|
SonarCloud Quality Gate failed. |
mnaturel
approved these changes
Dec 19, 2022
onurays
deleted the
feature/ons/fix_rename_session_keyboard_visibility
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
For a better UX, if an EditText is focused and the keyboard is already shown after showing and hiding a bottom sheet then the expected behavior is to show the keyboard by default.
Motivation and context
UX review remarks.
Screenshots / GIFs
show_keyboard_after_bottomsheet.mp4
Tests
Tested devices
Checklist