Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore the voice broadcast chunks at the notifications level #7845

Closed
giomfo opened this issue Dec 23, 2022 · 1 comment · Fixed by #7945
Closed

Ignore the voice broadcast chunks at the notifications level #7845

giomfo opened this issue Dec 23, 2022 · 1 comment · Fixed by #7945
Assignees
Labels
A-Voice Broadcast Broadcast-style voice messages T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@giomfo
Copy link
Member

giomfo commented Dec 23, 2022

Your use case

What would you like to do?

During the notifications handling, we should notify only the first voice chunk of a voice broadcast, and ignore the other events related to the voice broadcast chunks

Why would you like to do it?

These events are not displayed in the room timeline, they should not be taken into account in the notifications count.
They are voice messages marked as voice broadcast chunks (they refer to a voice message state event)

There is no case where the user may want to be notified on these chunks, they are supposed to be invisible for them. That is why we can hardcode this mechanism client side without adding config in push rules

How would you like to achieve it?

We have to ignore them locally, because these events are encrypted, we could not ignore them server side

Have you considered any alternatives?

No response

Additional context

No response

Are you willing to provide a PR?

Yes

@giomfo giomfo added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements A-Broadcast A-Voice Broadcast Broadcast-style voice messages labels Dec 23, 2022
@RiotRobot RiotRobot added this to Incoming in Issue triage Dec 23, 2022
@giomfo
Copy link
Member Author

giomfo commented Dec 23, 2022

related to element-hq/element-ios#7208

@giomfo giomfo removed the A-Broadcast label Jan 6, 2023
@RiotRobot RiotRobot moved this from Incoming to Triaged in Issue triage Jan 6, 2023
@Florian14 Florian14 self-assigned this Jan 12, 2023
Issue triage automation moved this from Triaged to Closed Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Voice Broadcast Broadcast-style voice messages T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants