Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Voice Broadcast] Move the live broadcast computation in the room list behind the lab flag #8042

Merged
merged 3 commits into from Jan 31, 2023

Conversation

Florian14
Copy link
Contributor

@Florian14 Florian14 commented Jan 31, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • The computation of the Live broadcast label in the room list is moved behind the voice broadcast lab flag. This is a temporary workaround before changing the current implementation.
  • Improve existing use case by removing a useless blocking call on a Kotlin Flow.

Motivation and context

The computation of the Live broadcast label introduced performance issues in the rendering of the room list because it requires a lot of DB queries as this cannot be done at the sdk level by updating the RoomSummaryEntity.

Screenshots / GIFs

Tests

  • Start a voice broadcast in a room
  • Verify that the live broadcast label is displayed or not in the room list according to the lab flag status

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@Florian14 Florian14 added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Jan 31, 2023
@Florian14 Florian14 requested review from a team and yostyle and removed request for a team January 31, 2023 09:34
@Florian14 Florian14 force-pushed the bugfix/fre/vb_move_last_message_behind_labs branch from ba3a2c3 to 2267d59 Compare January 31, 2023 10:02
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@yostyle yostyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jan 31, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

75.0% 75.0% Coverage
0.0% 0.0% Duplication

@Florian14 Florian14 merged commit bb8ebb7 into develop Jan 31, 2023
@Florian14 Florian14 deleted the bugfix/fre/vb_move_last_message_behind_labs branch January 31, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants