[Rich text editor] Add code block, quote and list indentation actions #8045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonnyandrew
force-pushed
the
feat/PSU-1099-rich-text-actions
branch
from
6eca590
to
eb8b378
Compare
jonnyandrew
requested review from
a team and
yostyle
and removed request for
a team
jonnyandrew
changed the title
jonnyandrew
force-pushed
the
feat/PSU-1099-rich-text-actions
branch
from
eb8b378
to
83110b8
Compare
yostyle
reviewed
Feb 8, 2023
| android:viewportHeight="44"> | ||
| <path | ||
| android:pathData="m18,22c0.7,-0.72 1.4,-1.4 2.1,-2.1 0.68,-0.98 -0.93,-1.9 -1.5,-0.96 -0.87,0.88 -1.8,1.7 -2.6,2.6 -0.45,0.67 0.27,1.2 0.7,1.6 0.75,0.74 1.5,1.5 2.2,2.2 0.98,0.68 1.9,-0.93 0.96,-1.5l-1.9,-1.9zM26.6,22c-0.71,0.72 -1.5,1.4 -2.1,2.2 -0.68,0.98 0.93,1.9 1.5,0.96 0.88,-0.89 1.8,-1.8 2.6,-2.7 0.45,-0.67 -0.27,-1.2 -0.7,-1.6 -0.75,-0.74 -1.5,-1.5 -2.2,-2.2 -0.99,-0.66 -2,0.94 -0.96,1.5l1.9,1.9zM13.6,32c-1.1,0.021 -1.9,-1 -1.7,-2.1 0.005,-5.7 -0.011,-11 0.008,-17 0.088,-1 1.1,-1.7 2.1,-1.5 5.6,0.005 11,-0.011 17,0.008 1,0.088 1.7,1.1 1.5,2.1 -0.005,5.6 0.011,11 -0.008,17 -0.088,1 -1.1,1.7 -2.1,1.5h-17zM13.6,30.3h17v-17h-17v17z" | ||
| android:fillColor="#8d97a5"/> |
There was a problem hiding this comment.
The color value is hardcoded.
Did you check the icons rendering when you change the app theme ?
There was a problem hiding this comment.
Good point, I've fixed this in 566d6e9
| Dark | Light |
|---|---|
 |
 |
|
Just noticed this issue based on my experience with the editor. Please put it out of beta with the addition of this. |
ElementBot
reviewed
Feb 8, 2023
| android:fillColor="#8D97A5" | ||
| android:fillType="evenOdd"/> | ||
| <path | ||
| android:fillColor="?vctr_content_tertiary" |
There was a problem hiding this comment.
⚠️ Resource references will not work correctly in images generated for this vector icon for API < 24; check generated icon to make sure it looks acceptable⚠️ Resource references will not work correctly in images generated for this vector icon for API < 24; check generated icon to make sure it looks acceptable
There was a problem hiding this comment.
I've checked the icons on API 21 and they are displaying OK
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Add code block, quote and list indentation actions to the rich text editor.
Motivation and context
PSU-1099Screenshots / GIFs
demo.webm
Tests
Tested devices
Checklist