Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for v2 of MSC3903 #8123

Merged
merged 5 commits into from Feb 16, 2023
Merged

Support for v2 of MSC3903 #8123

merged 5 commits into from Feb 16, 2023

Conversation

hughns
Copy link
Member

@hughns hughns commented Feb 13, 2023 •
edited

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Support for org.matrix.msc3903.rendezvous.v2.curve25519-aes-sha256 whilst maintaining compatibility with org.matrix.msc3903.rendezvous.v1.curve25519-aes-sha256
  • Improves the feedback in case of valid code but of unsupported algorithm or transport.
  • Added some test cases.

Motivation and context

Incorporates feedback from MSC review process.

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

Signed-off-by: Hugh Nimmo-Smith hughns@element.io

hughns and others added 5 commits February 13, 2023 15:07
@hughns
Support for v2 of MSC3903
2db75e2 
Improves the feedback in case of valid code but of unsupported algorithm or transport.
Added some test cases.
@hughns
Changelog
117eceb
@hughns
Lint
3a40223
@hughns
Spelling
f43c9bf
@hughns
Deduplicate error messages
e8f196a
@hughns hughns marked this pull request as ready for review February 14, 2023 18:13
@hughns hughns requested a review from bmarty February 14, 2023 18:13
@hughns hughns mentioned this pull request Feb 14, 2023
Merged
3 tasks
@sonarcloud
Copy link

sonarcloud bot commented Feb 14, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

bmarty
bmarty approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after a static review. Thanks!

@hughns hughns enabled auto-merge (squash) February 15, 2023 16:45
@hughns
Copy link
Member Author

hughns commented Feb 15, 2023

@bmarty thank you very much. Please can you override the Quality Gate check and merge?

@bmarty bmarty disabled auto-merge February 16, 2023 08:36
@bmarty bmarty merged commit e8ea538 into develop Feb 16, 2023
@bmarty bmarty deleted the hughns/msc3903-v2 branch February 16, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hughns @bmarty