Fix StackOverFlow exception when stop action is called within the tick event

[Florian14]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Verify if the timer is still running before calling the stop or pause action and triggering a new tick event

Motivation and context

Fix a regression introduced by #8058

Screenshots / GIFs

Tests

• Record a voice message
• Listen to the voice message until the end
• The timer should be correctly stopped and reset, the app should not freeze anymore

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes has been tested on an Android device or Android emulator with API 21
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop hotfix/1.5.25 branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR
• If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[bmarty]

Thanks. After discussion IRL, I think stop() and pause() should not invoke the tick listener. The caller could call elapsedTime() before invoking stop() or pause(). We may consider to do this change later (in EAx?).

Anyway I will merge and test on the hotfix branch and this will hopefully unblock the release.