Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend workaround for extra new lines in timeline #8187

Merged
merged 6 commits into from Mar 6, 2023
Merged

Extend workaround for extra new lines in timeline #8187

merged 6 commits into from Mar 6, 2023

Conversation

jonnyandrew
Copy link
Contributor

@jonnyandrew jonnyandrew commented Feb 28, 2023 •
edited

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Extend the workaround that fixes extra new lines inserted to the timeline by the Markwon library.

Note that this change does not seem to fix strikethrough.

Motivation and context

Closes #8179

This is a pre-existing bug caused by noties/Markwon#423 that is made more frequent by #8011

Screenshots / GIFs

N/A

Tests

See #8179

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 13

Checklist

@jonnyandrew jonnyandrew requested review from a team and yostyle and removed request for a team March 1, 2023 09:11
@jonnyandrew jonnyandrew marked this pull request as ready for review March 1, 2023 09:40
yostyle
yostyle approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@yostyle yostyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion if it's okay for you.

vector/src/main/java/im/vector/app/features/html/EventHtmlRenderer.kt Outdated Show resolved Hide resolved
@jonnyandrew @yostyle
Refactor
453d265 
Co-authored-by: Yoan Pintas <y.pintas@gmail.com>
@jonnyandrew jonnyandrew enabled auto-merge (squash) March 2, 2023 14:42
@sonarcloud
Copy link

sonarcloud bot commented Mar 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.9% 90.9% Coverage
0.0% 0.0% Duplication

@jonnyandrew jonnyandrew merged commit 29f2bf2 into develop Mar 6, 2023
@jonnyandrew jonnyandrew deleted the jonny/fix/timeline-newlines branch March 6, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yostyle yostyle yostyle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Formatting creates extra newlines
2 participants
@jonnyandrew @yostyle