Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for stable MSC3882 get_login_token #8299

Merged
merged 4 commits into from Jun 1, 2023
Merged

Conversation

hughns
Copy link
Member

@hughns hughns commented Apr 3, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Motivation and context

This adds support for the stable capability negotiation for the get login token endpoint used by Sign in with QR.

These PR leaves support for the unstable release 0 in place. It is my intention that the support for the unstable version would be removed in a future release once the stable support has made it into Synapse via matrix-org/synapse#15388.

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s): SDK 33

Checklist

Signed-off-by: Hugh Nimmo-Smith hughns@element.io

@sonarcloud

This comment was marked as outdated.

@hughns hughns changed the title Support for MSC3882 revision 1 Support for stable MSC3882 May 30, 2023
Remove unstable MSC3882 revision 1 support
@hughns hughns marked this pull request as ready for review May 30, 2023 17:31
@hughns hughns requested a review from bmarty May 30, 2023 17:37
@hughns hughns enabled auto-merge (squash) May 30, 2023 17:39
@sonarcloud
Copy link

sonarcloud bot commented May 30, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@hughns hughns changed the title Support for stable MSC3882 Support for stable MSC3882 get_login_token May 31, 2023
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Feel free to merge the PR.

@hughns hughns merged commit 61d4e46 into develop Jun 1, 2023
18 of 19 checks passed
@hughns hughns deleted the hughns/msc3882-r1 branch June 1, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants