Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fallbackKeySharingStrategy #8541

Merged
merged 1 commit into from Jun 16, 2023

Conversation

abaker
Copy link
Contributor

@abaker abaker commented Jun 14, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

This PR fixes the fallback key sharing strategy to return the correct value

Motivation and context

The fallback key sharing strategy was always set to OutboundSessionKeySharingStrategy.WhenSendingEvent regardless of the config setting

Checklist

Signed-off-by: Alex Baker <alex@beeper.com>
@abaker abaker force-pushed the fix_fallback_key_sharing_strategy branch from 7dff860 to 572bdb6 Compare June 14, 2023 21:29
@abaker abaker marked this pull request as ready for review June 14, 2023 21:30
@bmarty bmarty added the Z-Community-PR Issue is solved by a community member's PR label Jun 16, 2023
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@bmarty bmarty merged commit 4af2f70 into element-hq:develop Jun 16, 2023
14 of 15 checks passed
@abaker abaker deleted the fix_fallback_key_sharing_strategy branch June 16, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants