Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified Push: Ignore the potential SSL error when the custom gateway is testing #8683

Merged
merged 2 commits into from Nov 15, 2023

Conversation

giomfo
Copy link
Member

@giomfo giomfo commented Nov 15, 2023

When the Unified Push is enabled, the application checks the potential custom gateway before applying it. If an SSL error happens, the application may ignore this error and keep using this custom gateway. The actual SSL check will be done server side where this gateway is actually used.

Signed-off-by: giomfo gforet@matrix.org

…is testing

When the Unified Push is enabled, the application checks the potential custom gateway before applying it. If an SSL error happens, the application may ignore this error and keep using this custom gateway. The actual SSL check will be done server side where this gateway is actually used.
@giomfo giomfo requested a review from bmarty November 15, 2023 16:22
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks!

Copy link

sonarcloud bot commented Nov 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@ElementBot
Copy link

ElementBot commented Nov 15, 2023

Warnings
⚠️ Please add a reviewer to your PR.

Generated by 🚫 dangerJS against ee2fd9f

@giomfo giomfo merged commit fd5530a into develop Nov 15, 2023
16 checks passed
@giomfo giomfo deleted the giomfo/fix_custom_gateway_check branch November 15, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants