Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reporting super properties to posthog (appPlatform) #8839

Merged
merged 6 commits into from
May 31, 2024

Conversation

BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented May 28, 2024

Updated analytics events to latest version and report them properly

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@BillCarsonFr BillCarsonFr requested a review from bmarty May 28, 2024 07:27
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some non-blocking remarks.

@BillCarsonFr BillCarsonFr changed the title Support reporting super properties to posthog (plateformCode) Support reporting super properties to posthog (appPlatform) May 29, 2024
@BillCarsonFr BillCarsonFr requested a review from bmarty May 29, 2024 15:50
… not need a session to get the value.

This simplify a lot accessing this data.
@ElementBot
Copy link

Warnings
⚠️

vector/build.gradle#L133 - A newer version of androidx.media:media than 1.6.0 is available: 1.7.0

⚠️

vector/build.gradle#L133 - A newer version of androidx.media:media than 1.6.0 is available: 1.7.0

⚠️

vector/build.gradle#L134 - A newer version of androidx.transition:transition than 1.4.1 is available: 1.5.0

⚠️

vector/build.gradle#L134 - A newer version of androidx.transition:transition than 1.4.1 is available: 1.5.0

⚠️

vector/build.gradle#L137 - A newer version of org.threeten:threetenbp than 1.4.0 is available: 1.4.4

⚠️

vector/build.gradle#L137 - A newer version of org.threeten:threetenbp than 1.4.0 is available: 1.4.4

⚠️

vector/build.gradle#L205 - A newer version of androidx.browser:browser than 1.5.0 is available: 1.8.0

⚠️

vector/build.gradle#L205 - A newer version of androidx.browser:browser than 1.5.0 is available: 1.8.0

⚠️

vector/build.gradle#L243 - A newer version of androidx.emoji2:emoji2 than 1.3.0 is available: 1.4.0

⚠️

vector/build.gradle#L243 - A newer version of androidx.emoji2:emoji2 than 1.3.0 is available: 1.4.0

⚠️

vector/build.gradle#L327 - A newer version of org.jetbrains.kotlin:kotlin-reflect than 1.8.21 is available: 1.8.22

⚠️

vector/build.gradle#L327 - A newer version of org.jetbrains.kotlin:kotlin-reflect than 1.8.21 is available: 1.8.22

Generated by 🚫 dangerJS against 7e41d73

@BillCarsonFr BillCarsonFr merged commit 47bb23a into develop May 31, 2024
11 of 12 checks passed
@BillCarsonFr BillCarsonFr deleted the feature/bca/add_platformcode_to_posthog branch May 31, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants