Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mac os header bar #1245

Closed
germain-gg opened this issue Sep 22, 2023 · 5 comments · Fixed by #1272
Closed

mac os header bar #1245

germain-gg opened this issue Sep 22, 2023 · 5 comments · Fixed by #1272
Assignees

Comments

@germain-gg
Copy link
Contributor

Your use case

What would you like to do?

Screenshot 2023-09-22 at 15 01 56

Why would you like to do it?

Matches waht a lot of app do

SCR-20230921-luqf

Have you considered any alternatives?

No response

Additional context

No response

@germain-gg germain-gg self-assigned this Sep 22, 2023
@t3chguy t3chguy transferred this issue from element-hq/element-web Sep 22, 2023
@t3chguy
Copy link
Member

t3chguy commented Sep 22, 2023

This is different to how other chat apps do it

Beeper:
image

Discord:
image

WhatsApp:
image

Slack:
image

Telegram has the legacy window bar:
image

I frankly can't find any mainstream macOS chat app which does this, not even iMessage:
image

@janogarcia
Copy link

janogarcia commented Sep 22, 2023

So, the reason for introducing the extra padding on the top is twofold:

  • The new room header being clickable leaves very little room for forgiving, comfortable target areas for dragging the window. It requires the user to precisely hunt for tiny spots, which makes for a poor UX.
  • It also helps fix the alignment of the search bar and room header keylines with that of the space panel.

Examples of apps include Messenger and Signal, as shown in the issue description.

Also, this will evolve as we iterate on the new design for the left panel.

/cc @americanrefugee @nadonomy

@t3chguy
Copy link
Member

t3chguy commented Sep 22, 2023

I think it'll be poor for accessibility if it is styled as

image

there's no visual sign that I can drag above the text but not between the text and the call button

@janogarcia
Copy link

The pointer will change when hovering the active area of the room header, and then there's also a missing on hover background change which is not currently implemented (subtle, but we don't rely on it for accessibility, as the pointer change is already a sufficient change/signifier).

So, you'd get clear, visual feedback.

@nadonomy
Copy link
Member

@t3chguy fwiw when we discussed this, we looked at a lot of the references you posted. To make them work well, we need to also re-jig the left panels, which is out of scope for now.

We're expecting to solve this better over time, for now this is just a very sensible stopgap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants