Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element Desktop: CTRL + "+" does not increase font size #810

Open
pjaap opened this issue Sep 16, 2021 · 3 comments
Open

Element Desktop: CTRL + "+" does not increase font size #810

pjaap opened this issue Sep 16, 2021 · 3 comments

Comments

@pjaap
Copy link

pjaap commented Sep 16, 2021

Steps to reproduce

On the current (and previous) versions of Element Desktop (Version of Element: 1.8.5 Version of Olm: 3.2.3, Debian 11, KDE Plasma 5.21) you can decrease the global font size by CTRL + "-" but not increase again by CTRL + "+". Then you are stuck with tiny letters. On some machines the "+" from the numpad works, but not from external keyboards. Commands like CTRL + 0 do not work.

TL;DR: CTRL + "-" is not revertible!

What happened?

What did you expect?

CTRL + "+" increases font size

What happened?

Nothing :(

Operating system

Debian 11, KDE Plasma 5.21 (fails both on X11 and Wayland)

Application version

Version of Element: 1.8.5 Version of Olm: 3.2.3

How did you install the app?

https://packages.riot.im/debian/

Homeserver

matrix.tu-dresden.de

Have you submitted a rageshake?

No

@pjaap pjaap added the T-Defect label Sep 16, 2021
@t3chguy
Copy link
Member

t3chguy commented Oct 11, 2021

image

Don't forget that on most keyboards, + (on the number row) is Shift + = so the actual key combination is Ctrl + Shift + =

Can you confirm you are actually inputting the right sequence rather than Ctrl + = which is incorrect?

Commands like CTRL + 0 do not work.

I cannot reproduce this, works fine for me. Would be very helpful if you included more details about your environment, e.g your physical keyboard layout and your OS level keyboard layout settings.

@pjaap
Copy link
Author

pjaap commented Oct 11, 2021

Hi! thanks for the input!
I am on a German keyboard layout. Here, "+" has its own key. But using Ctrl+Shift+"+" also increases font size (is the shortcut internally mapped to the US layout?)

The context menu looks as follows:
grafik

Clicking on "vergrößern" actually increases the font size, too.

@t3chguy
Copy link
Member

t3chguy commented Oct 11, 2021

The shortcut mapping is handled by Electron's Accelerators https://www.electronjs.org/docs/api/accelerator

On macOS both Cmd+= and Cmd+Shift+= work, as intended by element-hq/element-web#8381

This latest issue you are having seems limited to a subset of keyboard layouts and is tracked upstream as electron/electron#29996

@t3chguy t3chguy transferred this issue from element-hq/element-web Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants