Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make checkbox UI consistent #3913

Open
domoritz opened this issue Jan 11, 2021 · 4 comments
Open

Make checkbox UI consistent #3913

domoritz opened this issue Jan 11, 2021 · 4 comments

Comments

@domoritz
Copy link

Describe the bug
Different checkboxes use various styles. They should all use native UI elements instead.

I didn't even realize that I could check the circle for quite a while. I think this will trip up many first time users and should therefore be fixed.

Screenshots

image

@aaronraimist
Copy link
Contributor

Do you have a screenshot of the native checkbox UI you are expecting? I agree the unchecked circle isn't very visually helpful as to what it is but as far as I can tell it is essentially the same as the checkboxes as in the system apps. For example these are in the Messages app

Screenshot 1

and these are in Settings

Screenshot 2

@domoritz
Copy link
Author

domoritz commented Nov 3, 2021

I think the circled checkboxes are quite rare. I see multi selects with submenus a lot more often. For example, in the rest of the notification setting ui.

image

@ShadowJonathan
Copy link
Contributor

I think the rounded checkboxes need extra context before they can be used as such, for example, these are presented in context of other objects, which themselves then lend a context to be 'selectable'.

Some extra data from #5277;

https://twitter.com/MrPseu/status/1467846022567280640

A person got stuck on the ToS screen because of this, and so i think using SwiftUI toggles for single button settings is the way forward.

@ShadowJonathan
Copy link
Contributor

What's more, the following StackOverflow answer says the following RadioButton style is prevalent across iOS, and it took me a moment to actually realise thats true;

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants