Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: "Upload from link" #1247

Open
Edszx opened this issue Aug 30, 2017 · 10 comments
Open

Suggestion: "Upload from link" #1247

Edszx opened this issue Aug 30, 2017 · 10 comments
Labels

Comments

@Edszx
Copy link

Edszx commented Aug 30, 2017

Currently, if we upload a media file that chrome can play (webm, mp4, mp3, ogg, opus) Riot invokes a media player in the message along with the file download link, can we have something like this but for pasted links from the net? (im not even talking about youtube links, but links that directly go to media files like example.com/song.opus)

@t3chguy
Copy link
Member

t3chguy commented Aug 30, 2017

This would expose your IP Address to the host and thus is considered unsafe, the only other way would be for Synapse to download it on your behalf which would probably not be instantaneous.

@Edszx
Copy link
Author

Edszx commented Aug 30, 2017

Uploading files from links (possibly with a server-side configurable size limit to prevent abuse) sounds like a very good idea too.

@t3chguy
Copy link
Member

t3chguy commented Aug 30, 2017

another issue stems from this automatic upload, the file might not be loadable by Javascript due to CORS

@Edszx
Copy link
Author

Edszx commented Aug 30, 2017

In that case, the client couldn't just give us an error message saying that it can't download the file?
Also, with this second idea, im no longer talking about making the cross-upload automatic when the link is sent to the chatroom, now im talking about maybe adding the option to "upload from link" to the current "upload file" button.

@t3chguy
Copy link
Member

t3chguy commented Aug 30, 2017

@Edszx I like the upload from link idea, but it might still hit CORS issues

@t3chguy
Copy link
Member

t3chguy commented Aug 30, 2017

(unless server accepted a link and downloaded it itself, but that'd require protocol changes)

@turt2live
Copy link
Member

fwiw, youtube embeds are covered here: https://github.com/vector-im/riot-web/issues/3466

@Edszx Edszx changed the title Invoke inline media player when a playable link is posted in the chatroom Suggestion: "Upload from link" Aug 30, 2017
@Edszx
Copy link
Author

Edszx commented Aug 30, 2017

@turt2live Yep, i saw that issue some days ago, but this situation is not the same, nevertheless, both things would be very good additions, i hope the devs could consider them for when they feel like it.

@ShadowJonathan
Copy link

Related; discord obscures linked media by embedding it as if it was any normal uploaded media.

This isnt maybe an approach Element would have to take (due to security concerns), but at least maybe providing the option to "download the link, and then upload it" for power users, with a similar "simple" mechanism of copying a media link whole-sale into the composer, would be interesting.

@MadLittleMods
Copy link

Related to element-hq/element-web#437

@t3chguy t3chguy transferred this issue from element-hq/element-web Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants