Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joining a room should be more transparent for the user #1464

Open
devnoname120 opened this issue Mar 21, 2017 · 4 comments
Open

Joining a room should be more transparent for the user #1464

devnoname120 opened this issue Mar 21, 2017 · 4 comments

Comments

@devnoname120
Copy link

Description

When I access a room, there is a banner explaining that I need to join the room in order to send messages.

Instead, I would like this banner not to appear, and automatically join the room as I type my first message.

Same for private discussions, I'm not sure why I need to manually click on join the conversation, this feels annoying, especially as a former IRC client user.

@lampholder lampholder added S-Tolerable Low/no impact on users X-Needs-Info This issue is blocked awaiting information from the reporter and removed S-Tolerable Low/no impact on users X-Needs-Info This issue is blocked awaiting information from the reporter labels Mar 22, 2017
@lampholder
Copy link
Member

I believe the intention of this behaviour is to give the user an opportunity to 'peek' into the room before committing themselves to visibly joining.

The act of joining is therefore then a very deliberate action, so it should be clear to the user that they are making a choice to change their state, from peeking to a full member of the room.

@ara4n - can you confirm or deny my interpretation of this feature?

@ara4n
Copy link
Member

ara4n commented Mar 22, 2017

correct. and if peeking is not enabled, the prompt serves to let users explicitly opt into invitations or following room urls etc.

however, if the room has no peeking and the user explicitly tried to join it from the UI (by /join, or using the room directory, or following a link) i think it would be fine to join without the confirmation screen.

@devnoname120
Copy link
Author

I find it the most annoying for PM's. For example if a IRC user sends me a message, I find it a burden - especially for one-time one-line chats - to click on 'join this room' and needing to wait for some short time before the messages appear.

I think that the default desired behavior for clicking on join from the UI or typing /join is actually joining the room, not peeking in it. Maybe a /peek command could be added?

@lampholder
Copy link
Member

I think we could probably all agree that it would be good for the behaviour of this feature to be configurable according to individual user preferences.

The explicit opt-in is a safe default (having to accept requests to send inbound messages limits risk of abuse), but I'm sure some power users would prefer to be dropped straight into the chat, so let's wrap this up by defining it as a 'configurable peek/join behaviour' feature request and adding to the priority list :)

I'm assigning this P3 to represent that we're not planning on doing it in the immediate term, but would be happy to see pull requests from the community :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants