Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] Voice Messages - Phase 1 #2057

Closed
9 of 15 tasks
langleyd opened this issue Sep 20, 2023 · 3 comments
Closed
9 of 15 tasks

[Epic] Voice Messages - Phase 1 #2057

langleyd opened this issue Sep 20, 2023 · 3 comments
Labels
AirFocus - EX Feature - Epic App: ElementX Android App: ElementX iOS T-Epic Issue is at Epic level Team: Element X Feature Z-AirFocus Moving issues from GH to AirFocus purposefully using this tag.

Comments

@langleyd
Copy link
Contributor

langleyd commented Sep 20, 2023

After phase 1, voice messages can be sent, received and played in the timeline. They can be previewed and are integrated into other features such as notifications and room summaries. Some functionality may come for free as part of pre-existing features.

Note the that send and preview are split into separate stories to flush out challenges in sending earlier.

Based on

Note that for compatibility with classic Element apps, this implementation will be based on an older version of MSC3245 called 'v1' (see matrix-org/matrix-spec-proposals#3245 (comment)).

User Stories

  1. 18 of 23
    App: ElementX Android App: ElementX iOS T-User Story Team: Element X Feature X-Needs-Signoff
    nimau
  2. 16 of 25
    App: ElementX Android App: ElementX iOS T-User Story Team: Element X Feature X-Needs-Signoff
    alfogrillo jonnyandrew
    nimau
  3. 2 of 3
    App: ElementX Android App: ElementX iOS T-User Story Team: Element X Feature
    jonnyandrew
  4. 10 of 19
    App: ElementX Android App: ElementX iOS T-User Story Team: Element X Feature X-Needs-Signoff
    jonnyandrew nimau
  5. 2 of 4
    App: ElementX Android App: ElementX iOS T-User Story Team: Element X Feature X-Needs-Signoff
    jonnyandrew nimau
  6. 17 of 19
    App: ElementX Android App: ElementX iOS T-User Story Team: Element X Feature X-Needs-Signoff
    alfogrillo
  7. 1 of 5
    App: ElementX Android App: ElementX iOS T-User Story Team: Element X Feature X-Needs-Signoff
    alfogrillo
  8. 1 of 2
    App: ElementX Android App: ElementX iOS T-User Story Team: Element X Feature X-Needs-Signoff
    nimau

Open questions

Rust

Out of scope

Sign-off

Android

iOS

References

Technical lead: @jonnyandrew

myhours project: Element X

@callumu
Copy link

callumu commented Oct 25, 2023

Some design comments for iOS FYI @alfogrillo:

  • Hold to record tooltip should be moved so that the point of the tooltip is centered above the microphone icon
  • Tooltip text size should be body/sm/semibold
  • If the keyboard is shown, selecting and holding to record a voice message shouldn't hide the keyboard
  • Can you remove the border colour for the recording UI in the composer?
  • Can the red dot blink instead of being stationary?
  • Can we add the green scrubber in the preview before sending? Don't worry if it's too time consuming - we can add this in the next version
  • Play and pause icon should be 24px like in the designs - can you double check these?
  • Can the change between the play and pause icon be instant? Right now there's a blinking effect on the whole button which shouldn't be there

@alfogrillo
Copy link

alfogrillo commented Oct 25, 2023

@callumu can clarify some of the above?

Can you remove the border colour for the recording UI in the composer?

You mean removing the border after the a record (in the preview), or during it?

Can the change between the play and pause icon be instant? Right now there's a blinking effect on the whole button which shouldn't be there

I think the button is fading during the user interaction (the press on the button) like most of our buttons do in the app.
Are you suggesting to remove this behavior here?

@callumu
Copy link

callumu commented Oct 25, 2023

You mean removing the border after the a record (in the preview), or during it?

Oh yes sorry I mean during both.

I think the button is fading during the user interaction (the press on the button) like most of our buttons do in the app. Are you suggesting to remove this behavior here?

For this use case yes. Either that or with a much faster fade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AirFocus - EX Feature - Epic App: ElementX Android App: ElementX iOS T-Epic Issue is at Epic level Team: Element X Feature Z-AirFocus Moving issues from GH to AirFocus purposefully using this tag.
Projects
None yet
Development

No branches or pull requests

4 participants