Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] Show a "@" badge in the room-list if a user has mentioned me in a room #2064

Closed
5 tasks done
VolkerJunginger opened this issue Sep 22, 2023 · 7 comments
Closed
5 tasks done
Assignees
Labels
App: ElementX Android App: ElementX iOS T-User Story X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA

Comments

@VolkerJunginger
Copy link
Contributor

VolkerJunginger commented Sep 22, 2023

Story

As a user that has been mentioned in a room I want to see a badge in the room-list so that I can see that I have been mentioned right away.

Figma link: TBD

Acceptance criteria

  • Show a badge "@" for the user that has been mentioned in a room
  • The badge "@" must stay if the room gets a limited flag
  • Hide the badge when the user has seen the message that is mentioning them

@amshakal Not sure about this.

Size estimate

M

Preconditions

  • We might need a better mark read room logic

Subtasks - Deadline 21st December

Android

  1. A-Room List T-Enhancement
    bmarty

iOS

  1. A-Room-List T-Enhancement
    Velin92

Rust

  1. A-Room-List X-Needs-Rust Z-Schedule
    bnjbvr

Design

Extra Goals for 2024

Rust

  1. A-Room-List X-Needs-Rust Z-Schedule
    bnjbvr
  • QA signoff on completion
  • Design signoff on completion
  • Product signoff on completion
@Velin92
Copy link

Velin92 commented Sep 28, 2023

Was mentioned here that we would also require to improve the mark room read logic to avoid, the read marker in the room list to be inconsistent:
matrix-org/matrix-rust-sdk#2607

Maybe is worth opening an issue for such a task or a story for this too?
@VolkerJunginger @manuroe

@amshakal
Copy link

What do we mean by limited flag?

@bnjbvr
Copy link
Member

bnjbvr commented Dec 21, 2023

Can we close this now?

@manuroe
Copy link
Member

manuroe commented Dec 21, 2023

yes, QA will happen at the epic level

@manuroe manuroe closed this as completed Dec 21, 2023
@manuroe manuroe reopened this Dec 21, 2023
@manuroe manuroe closed this as completed Dec 21, 2023
@manuroe
Copy link
Member

manuroe commented Dec 22, 2023

We had to ignore the new feature in the SDK. We need to come back to it next year.

@manuroe manuroe reopened this Dec 22, 2023
@bnjbvr bnjbvr self-assigned this Dec 22, 2023
@bnjbvr
Copy link
Member

bnjbvr commented Jan 22, 2024

The SDK part is now fixed, should we close this again, after manual QA verification maybe? cc @manuroe @VolkerJunginger

@bnjbvr bnjbvr removed their assignment Jan 22, 2024
@bnjbvr bnjbvr added the X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA label Jan 22, 2024
@manuroe
Copy link
Member

manuroe commented Jan 29, 2024

Final tests will happen at the epic level

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App: ElementX Android App: ElementX iOS T-User Story X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA
Projects
None yet
Development

No branches or pull requests

7 participants