Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Threads: Thread replies to root messages going unnoticed #235

Closed
Tracked by #187
novocaine opened this issue Apr 25, 2022 · 5 comments
Closed
Tracked by #187

My Threads: Thread replies to root messages going unnoticed #235

novocaine opened this issue Apr 25, 2022 · 5 comments

Comments

@novocaine
Copy link

novocaine commented Apr 25, 2022

We're updating this issue to be more specific as the original content is now split into 2 solutions.

  1. Updating Notifications so that messages are not missed will be tracked by Threads: Improve Notifications for Exit Beta #196
  2. this issue The "My Threads" filter in the Thread Panel should include threads that my message is the root message.

Solution

This is fixed by the thread list API


The original issue content

Current implementation prevents you from being notified when someone starts a thread on one of your messages without mentioning or quoting you.

“My threads” should include threads where I’m the author of the root message even if I didn’t reply to it or no one mentioned me directly.

Failing to implement it means users will be missing replies to their messages.

User A post a message in the main timeline.
User B starts a thread for User A message, without directly mentioning him (e.g., User B message is That looks promising. Any chance I can test the service before I commit to your contract?)
User A never gets a notification for User B request.
Missed business opportunity.

@novocaine
Copy link
Author

@clokep said:

Yeah, that seems like it might be a design flaw in what we put together.
I think we could just consider it an implementation bug in terms of the current_user_participated bit, but I don't think the filters allows you to find it easily.

@clokep
Copy link
Contributor

clokep commented Jul 27, 2022

MSC3856 should help with this case.

@daniellekirkwood
Copy link
Contributor

This should be fixed with the notifications work that we're doing for the Exit Beta Milestone @gsouquet / @clokep ?

@clokep
Copy link
Contributor

clokep commented Sep 6, 2022

This should be fixed with the notifications work that we're doing for the Exit Beta Milestone @gsouquet / @clokep ?

This issue is a bit confusing -- it isn't really related to notifications, but to the way we display threads under "My Threads". It should be fixed as part of the threads list API added in MSC3856 as part of the exit beta work.

@daniellekirkwood daniellekirkwood changed the title Thread notifications: Thread replies to root messages going unnoticed My Threads: Thread replies to root messages going unnoticed Sep 6, 2022
@clokep
Copy link
Contributor

clokep commented Jan 24, 2023

This is done -- from a technical POV this ended up being the same solution from #195.

@clokep clokep closed this as completed Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants