Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle failures when publishing cross-signing identity #2410

Open
5 tasks
richvdh opened this issue Apr 29, 2024 · 3 comments
Open
5 tasks

Handle failures when publishing cross-signing identity #2410

richvdh opened this issue Apr 29, 2024 · 3 comments

Comments

@richvdh
Copy link
Member

richvdh commented Apr 29, 2024

When first logging in on a new account, we try to publish cross-signing keys (via /device_keys/upload).

This process can fail for example, if the homeserver is configured to use SSO auth. (Publishing the public keys requires user-interactive auth, which may fail. matrix-org/matrix-spec-proposals#3967 is an attempt to help with that, but is as yet unstandardised.)

If the process fails (either because the HS rejects it or the user gets bored of trying to do UIA and dismisses the dialog), we show an error:
image

After that point, the application is fully-functional, and will even allow you to set up 4S and store the private cross-signing keys in 4S. The problem is that there is no further attempt to publish the public keys, so the account is now totally broken until the user resets cross-signing.

Tasks

  1. encryption
  2. A-E2EE A-E2EE-Cross-Signing O-Occasional S-Major T-Defect
@richvdh
Copy link
Member Author

richvdh commented Apr 29, 2024

We should also finish MSC3967, which will remove many of the causes of this problem in the first place.

@andybalaam
Copy link

andybalaam commented May 13, 2024

This is part of "WebR Force Verification" https://github.com/element-hq/crypto-internal/issues/283

@richvdh
Copy link
Member Author

richvdh commented May 13, 2024

This is part of "WebR Force Verification"

It's not just Web R: all the other clients are affected too.

@uhoreg uhoreg assigned uhoreg and unassigned uhoreg May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants