Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Room upgrade modal: pressing enter doesn't upgrade the room, but "Upgrade" option is highlighted #11775

Open
anoadragon453 opened this issue Jan 5, 2020 · 3 comments
Open

Room upgrade modal: pressing enter doesn't upgrade the room, but "Upgrade" option is highlighted #11775

anoadragon453 opened this issue Jan 5, 2020 · 3 comments
Labels
A-Room-Upgrades T-Defect

Comments

@anoadragon453
Copy link
Member

image

I'm trying to upgrade a room. A dialog appears. I hit enter, thinking the highlighted option, "Upgrade" will be chosen. I wait and wait, but the room never gets upgraded!

Turns out hitting enter here hits "Cancel" instead.

Version information

  • Platform: web
  • Browser: Firefox Nightly
  • OS: Linux
  • URL: riot.im/develop
@t3chguy
Copy link
Member

t3chguy commented Jan 5, 2020

I think this might fall under general Modal accessibility where Enter should "Accept/Proceed" and Escape should "Cancel/Abort"

@t3chguy
Copy link
Member

t3chguy commented Jan 5, 2020

Related to #11362

@aaronraimist
Copy link
Collaborator

Related: #10702

@jryans jryans removed the Z-UI/UX label Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Room-Upgrades T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jryans @anoadragon453 @t3chguy @aaronraimist