Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaled avatar used for typing notifications could use normal size image #12050

Open
tdaede opened this issue Jan 24, 2020 · 1 comment
Open

Comments

@tdaede
Copy link

tdaede commented Jan 24, 2020

Description

On hidpi (but probably normal dpi too) the user avatars are 64x64 for messages, however for typing indicators they are 48x48. These turn into special GET requests to get resized images, however this means that there's a delay as the 48x48 typing indicator is loaded. In practice the 64x64 one will almost always be loaded (or will need to be loaded very soon) so this could simply always use the 64x64 asset (scaled down by the browser).

Steps to reproduce

Load a channel where someone has sent a message, then have them start typing.

Logs being sent: yes/no

Version information

  • Platform: web

For the web app:

  • Browser: Firefox 74
  • URL: v1.5.7-100-g9ee7febd
@t3chguy
Copy link
Member

t3chguy commented Apr 14, 2020

Good point, this falls into two issues

The requested image should be 2x/3x bigger than the render size for hidpi/zooming and also should be binned so that we deduplicate requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants