Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to tap on a room twice to view it (using Riot-Web on and iPad). #12202

Open
bwinton opened this issue Feb 2, 2020 · 8 comments
Open

Need to tap on a room twice to view it (using Riot-Web on and iPad). #12202

bwinton opened this issue Feb 2, 2020 · 8 comments

Comments

@bwinton
Copy link

bwinton commented Feb 2, 2020

Description

I'm testing out Riot-Web on Mobile Safari on an iPad, and whenever I tap a room to view it, it shows the ⠇button, but doesn't show the contents of the room.

Steps to reproduce

  • Use Riot-Web on Mobile Safari on an iPad
  • tap a room to view it

I expect it to show the contents of the room.
Instead it shows the ⠇button. 🙂

Logs being sent: no

Version information

  • Platform: web (in-browser)

For the web app:

  • Browser: Mobile Safari
  • OS: iPadOS 13.3.1
  • URL: chat.mozilla.org, using riot-web v1.5.7-100-g9ee7febd
@t3chguy
Copy link
Member

t3chguy commented Feb 4, 2020

How else would a widget with both an on-hover and on-click behaviour function on a touchscreen which cannot detect hover? This is not a riot specific thing, just how your browser is deciding to handle the lack of hover support.

@bwinton
Copy link
Author

bwinton commented Feb 4, 2020

What on-hover functionality is it exposing? Is that functionality more important than what I thought would be the more common task of switching rooms?

@t3chguy
Copy link
Member

t3chguy commented Feb 4, 2020

It is the only way to access its context menu:

image

@bwinton
Copy link
Author

bwinton commented Feb 4, 2020

What about showing the context menu when the room is selected instead? Do people change settings without entering the room that often?

@t3chguy
Copy link
Member

t3chguy commented Feb 4, 2020

That'd be undesirable in terms of design for users of mice, for touch-only devices sure it makes sense but what about then for touchscreen laptops which also have pointers and are hover-capable? Riot doesn't try to be touch compatible in many places

@bwinton
Copy link
Author

bwinton commented Feb 4, 2020

If it was done on a touch-event instead of a click-event, then it shouldn't be much of a problem.

Also, if we're going to be offering the web version to people on iPads, as mentioned in #10863 (comment) then perhaps adding touch-compatiblity in some of the more common places should be a goal… ¯_(ツ)_/¯

@t3chguy
Copy link
Member

t3chguy commented Feb 4, 2020

Sure, that'd solve the two-tap issue but not the selected room should have the context menu trigger exposed (it'd only be exposed until you tap somewhere else)

Safari on iPad lies and claims it is a full-blown Mac OSX device running Safari which it is not as you have found with this issue

@jryans
Copy link
Collaborator

jryans commented Feb 4, 2020

Also, if we're going to be offering the web version to people on iPads, as mentioned in #10863 (comment) then perhaps adding touch-compatiblity in some of the more common places should be a goal… ¯_(ツ)_/¯

We'll have to work out how we want to handle touch-specific things like that, yes.

I am in the process writing up a more detailed proposal for the Riot core team on what our level of support here should be, so that should help us answer questions like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants