Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key backup restore dialog overrides settings dialog #12230

Open
turt2live opened this issue Feb 4, 2020 · 6 comments
Open

Key backup restore dialog overrides settings dialog #12230

turt2live opened this issue Feb 4, 2020 · 6 comments

Comments

@turt2live
Copy link
Member

It should show up on top of the settings dialog, not replace it

@jryans
Copy link
Collaborator

jryans commented Feb 4, 2020

I agree this is not great, but I'll going to leave it out of cross-signing scope for now. I view it as a general symptom of modals needing a better stacking system.

@turt2live
Copy link
Member Author

It's a boolean we probably removed without realizing.

@jryans
Copy link
Collaborator

jryans commented Feb 4, 2020

I think it's actually that most of the cross-signing flows are also using static = true because the access secret storage dialog may appear on top of them.

That's what I mean, we are now finding ourselves possibly stacking up to 3 modals on top and need to preserve state in all of them. 😅

@turt2live
Copy link
Member Author

oh... well... ugh.

@sirocyl

This comment has been minimized.

@jryans

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants