Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject 4S key sharing requests after timeout #12664

Open
jryans opened this issue Mar 9, 2020 · 2 comments
Open

Reject 4S key sharing requests after timeout #12664

jryans opened this issue Mar 9, 2020 · 2 comments
Assignees
Labels
A-E2EE-Cross-Signing O-Uncommon Most users are unlikely to come across this or unexpected workflow Security T-Enhancement

Comments

@jryans
Copy link
Collaborator

jryans commented Mar 9, 2020

When verifying a new device, we use 4S key sharing requests behind the scenes to share various account-level private keys, such as your cross-signing private key and others, so that the new device can perform all the same security functions as the existing device used to verify it.

At the moment, these key sharing requests from a verified device are always accepted, even if the verification process happened a long time ago.

As an additional security measure, after N seconds have passed since a device was verified, we should silently reject 4S key sharing requests from it.

(The value of N is still up for discussion.)

@kittykat
Copy link
Contributor

"If the issue is targeting the „verify session notification“: this one gets closed after verification.
Not sure what it is really about"

I'm going to close this issue for now, please reopen if the above is not the case 👍

@jryans
Copy link
Collaborator Author

jryans commented Dec 16, 2021

This issue is more about a potential security improvement that was planned for cross-signing but not yet implemented. I have rewritten the issue body with more context. The Crypto team should take a look at this and evaluate whether it's something they want to take on.

@jryans jryans reopened this Dec 16, 2021
@jryans jryans added Security T-Enhancement O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Dec 16, 2021
@duxovni duxovni self-assigned this Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE-Cross-Signing O-Uncommon Most users are unlikely to come across this or unexpected workflow Security T-Enhancement
Projects
None yet
Development

No branches or pull requests

3 participants