Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to change audio quality in 1:1 calls #12739

Open
notramo opened this issue Mar 14, 2020 · 6 comments
Open

Option to change audio quality in 1:1 calls #12739

notramo opened this issue Mar 14, 2020 · 6 comments
Labels
A-VoIP O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement Z-Upstream

Comments

@notramo
Copy link

notramo commented Mar 14, 2020

Users with good microphones, fast computers, and fast network may want to have higher quality audio.
The Opus codec supports 6 kb/s to 510 kb/s bitrate! Why not utilize it?
High quality audio can be beneficial in many scenarios:

  • where high dynamic range is required, e.g. lot of people, some are further from the microphone (quiet), some are closer to it (louder)
  • musical events, music education
  • good quality microphone and headphones - Why not enjoy utilizing it fully to have a good conversation?

On the other hand, on slow networks, some people would settle for the lowest quality just to be able to talk.

I suggest that users could specify the bitrate with digits would be the most flexible solution. It should be changeable during a call, and Riot should save the last used bitrate for each user.

@marc107
Copy link

marc107 commented Apr 18, 2020

Appreciate this!

@jryans
Copy link
Collaborator

jryans commented Apr 20, 2020

Since Riot uses Jitsi for group calls, it sounds like this is most likely to happen if a request is filed with https://github.com/jitsi/jitsi-meet/issues.

@notramo
Copy link
Author

notramo commented Apr 20, 2020

@jryans Does Riot use Jitsi for 1:1 calls?

@jryans
Copy link
Collaborator

jryans commented Apr 20, 2020

@jryans Does Riot use Jitsi for 1:1 calls?

No. For 1:1 calls, Riot uses P2P WebRTC directly. It would depend on whether browsers offer such an option to control audio quality in that case.

@jryans
Copy link
Collaborator

jryans commented Apr 20, 2020

If this is more important for group vs. 1:1 calls, it might make sense to track with separate issues, as they are different paths, each with their own challenges.

@notramo notramo changed the title Option to change audio quality Option to change audio quality in 1:1 calls Apr 20, 2020
@BloodyIron
Copy link

Yeah really wish we could have actual controls over codecs and bitrates in 1:1. The quality really is not as good as I was hoping for. And getting 64-128kbps of upload rate is trivial now adays. We need options for those on limited connections, and those with plenty of bandwidth.

I too am really interested in this.

@SimonBrandner SimonBrandner added P3 and removed A-Jitsi labels Jul 30, 2021
@SimonBrandner SimonBrandner added O-Occasional Affects or can be seen by some users regularly or most users rarely and removed P3 labels Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-VoIP O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement Z-Upstream
Projects
None yet
Development

No branches or pull requests

6 participants