Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smoke test automatically applying dark theme in all browsers #12922

Closed
nadonomy opened this issue Mar 29, 2020 · 1 comment
Closed

Smoke test automatically applying dark theme in all browsers #12922

nadonomy opened this issue Mar 29, 2020 · 1 comment
Labels
A-Testing Testing, code coverage, etc. A-Theming

Comments

@nadonomy
Copy link
Contributor

nadonomy commented Mar 29, 2020 •
edited
Loading

In macOS/Safari at least, detecting the OS theme pref and applying the relevant theme in Riot doesn't seem to work. We should do a smoke test of all of our supported browsers and track issues to fix.
@nadonomy nadonomy changed the title R&D (again) detecting OS dark theme preferences and applying them on the web Smoke test automatically applying dark theme in all browsers Mar 29, 2020
@t3chguy t3chguy added the A-Testing Testing, code coverage, etc. label May 6, 2022
@Johennes
Copy link
Contributor

This appears to work correctly now in my testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Testing Testing, code coverage, etc. A-Theming
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jryans @Johennes @t3chguy @nadonomy