Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable VoIP calling buttons in room header when user doesn't have permission #13118

Open
aaronraimist opened this issue Apr 10, 2020 · 6 comments
Assignees
Labels
A-Jitsi A-Room-View O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement X-Needs-Design Z-Confidence-Medium Medium confidence in the enhancement or suggestion based on known factors, or as described.

Comments

@aaronraimist
Copy link
Collaborator

If you don't have permission to start a call the calling button should be grayed out or otherwise disabled

@iav
Copy link

iav commented Jul 24, 2020

I vote for removing and free space.

@jryans jryans removed the Z-UI/UX label Mar 8, 2021
@peter-czy
Copy link

This should probably be something for the design team to think about?
I personally prefer to have them removed for rooms where you don't have permission to start a call.

@janogarcia
Copy link

janogarcia commented Jan 31, 2022

Adding some clarifications shared by Dave:

  • In 1:1 rooms anyone can start a call.
  • In rooms with > 2 people you need either to be an Admin/Mod in order to start a call, or the room needs to allow regular users to create widgets.
  • The buttons don't have any indication for state (ongoing call, failed calls, no permission...).

@SimonBrandner SimonBrandner added O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist labels Jan 31, 2022
@janogarcia janogarcia self-assigned this Jan 31, 2022
@turt2live turt2live changed the title Disable VoIP calling buttons in composer when user doesn't have permission Disable VoIP calling buttons in room header when user doesn't have permission May 17, 2022
@turt2live
Copy link
Member

they moved to the room header ftr

@nadonomy
Copy link
Contributor

My fear is if the buttons disappear and people don't know why they're not able to educate themselves, so I think for this to work we'd need to have some helper copy somewhere in room settings.

@SimonBrandner
Copy link
Contributor

My fear is if the buttons disappear and people don't know why they're not able to educate themselves, so I think for this to work we'd need to have some helper copy somewhere in room settings.

disappear? I would think we just make them a little gray and add an informative tooltip, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Jitsi A-Room-View O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement X-Needs-Design Z-Confidence-Medium Medium confidence in the enhancement or suggestion based on known factors, or as described.
Projects
None yet
Development

No branches or pull requests

10 participants