Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Verify this session" dialogues don't appear in "other" sessions #13938

Open
JOJ0 opened this issue Jun 5, 2020 · 10 comments
Open

"Verify this session" dialogues don't appear in "other" sessions #13938

JOJ0 opened this issue Jun 5, 2020 · 10 comments

Comments

@JOJ0
Copy link

JOJ0 commented Jun 5, 2020

Description

I just upgraded my Riot-Web Installation from 1.5.15 to 1.6.4

Cross-Signing does not seem to work

Steps to reproduce

  • One session has been verified using the "Recovery Passphrase" already, running in browser Safari
  • Log into Riot with new browser (eg. Chrome)
  • "Verify this session" screen appears and waits that users connect to "other" compatible session (1.6.0+ or latest iOS in my case)
  • Go to any other compatible riot-web session or riot-iOS session (eg: Safari session or iOS session)
  • No qr-code screens and/or emoji-screens appear on the other sessions. The verification process appears not to be working
  • Only the last resort solution "Use Recovery Passphrase" seems to be working.

I would expect that when I head over to another session, automatically the "verification qr-code, emoji screens appear and walk me through the cross-signing process"

Logs being sent: yes

Screen Shot 2020-06-05 at 19 16 26

Screen Shot 2020-06-05 at 19 16 32

Version information

  • Platform: web (in-browser)

For the web app:

  • Browsers:
    • Verified session: Safari 13.1 (13609.1.20.111.8)
    • Unverified/to be verified session: Chrome: 83.0.4103.61 (Official Build) (64-bit)
  • OS: macOS
  • riot-web self-hosted version 1.6.4

iOS App:

  • version 0.11.5 (latest as of 2020-06-05)
@JOJ0 JOJ0 added the T-Defect label Jun 5, 2020
@t3chguy
Copy link
Member

t3chguy commented Jun 5, 2020

image

Where is this screenshot from?


When I log in with a new session B, I observe the following:

image

At the same time, on session A I observe:

image

upon clicking Verify on A I get the following on A:

image

Upon clicking Continue I get the following on A and B respectively:

image
image

@Ghabry
Copy link

Ghabry commented Jun 5, 2020

This also happened to me once. On one device I got no prompt on any other device about cross-signing/device trust. Had to use the recovery passphrase but on all others it worked. So this issue seems to be quite random?

@JOJ0
Copy link
Author

JOJ0 commented Jun 6, 2020

image

Where is this screenshot from?

When I log in to the "new" (to be verified) session in Chrome browser. It pops up in the very top-left of the browser window.

When I log in with a new session B, I observe the following:

Thanks for your pictures, this clarifies what to expect, In my case just nothing happens when opening any of my other sessions.

@t3chguy
Copy link
Member

t3chguy commented Jun 6, 2020

image

So both of those screenshots were from the same session and in the backwards order?

@JOJ0
Copy link
Author

JOJ0 commented Jun 7, 2020

same session in the order I posted them.

@formbi-kupiec

This comment has been minimized.

@jryans

This comment has been minimized.

@JOJ0
Copy link
Author

JOJ0 commented Jun 20, 2020

Hi,
if you need anythin else please get back to me. I sent logs, did you actually receive them?
Thanks a lot for your time and all the best!
Jojo

@jryans
Copy link
Collaborator

jryans commented Jun 22, 2020

Yes, we received the debug logs you included when originally filing. Thanks, we'll take a look.

@Ghabry
Copy link

Ghabry commented Jun 30, 2020

Is kinda unrelated I guess but you could also try this:
#13824 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants