Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New room list: Tile context menu for tagging #14269

Closed
2 tasks
turt2live opened this issue Jun 29, 2020 · 3 comments
Closed
2 tasks

New room list: Tile context menu for tagging #14269

turt2live opened this issue Jun 29, 2020 · 3 comments
Labels
A-Room-List X-Needs-Design

Comments

@turt2live
Copy link
Member

turt2live commented Jun 29, 2020 •
edited
Loading

Outstanding concerns:

  • Considering New room list: Archived view #14038, what are the options themselves?
    • Currently we have Favourite and Low Priority, but if Low Priority goes away then the favourite interaction might feel bare.
  • Designs needed for toggled-on state (bold?).

Development:

  • Make it work
  • Designs as appropriate
@turt2live turt2live added this to TODO in Room List v2 via automation Jun 29, 2020
This was referenced Jun 29, 2020
Closed
Closed
@t3chguy
Copy link
Member

t3chguy commented Jun 30, 2020

Designs needed for toggled-on state (bold?).

Presumably this should match the Notifications menu which gets accented and a checkmark:

image

@t3chguy
Copy link
Member

t3chguy commented Jun 30, 2020

matrix-org/matrix-react-sdk#4858 gets rid of the Low Priority option as per the design

@turt2live
Copy link
Member Author

Actually going to merge this in with #14038 for ease of representation

Room List v2 automation moved this from TODO to Done 🎉 Jul 1, 2020
@turt2live turt2live removed this from Done 🎉 in Room List v2 Jul 1, 2020
@turt2live turt2live mentioned this issue Jul 1, 2020
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Room-List X-Needs-Design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jryans @turt2live @t3chguy