Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji autocomplete is very slow #15649

Open
f0x52 opened this issue Nov 5, 2020 · 8 comments
Open

Emoji autocomplete is very slow #15649

f0x52 opened this issue Nov 5, 2020 · 8 comments
Labels
A-Autocomplete A-Composer A-Emoji A-Performance O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter

Comments

@f0x52
Copy link

f0x52 commented Nov 5, 2020

Description

When typing text emoticons like :P the whole UI freezes, calculating the possible emoji shortcode completions.

Steps to reproduce

just typing a :P
it's not quite 100% reproducible, but rather consistent

Logs being sent: yes

Version information

  • Platform: web

For the web app:

  • Browser: Firefox developer 83.0b6
  • OS: btw i use Arch Linux
  • URL: riot.im/develop
@f0x52 f0x52 added the T-Defect label Nov 5, 2020
@dbkr
Copy link
Member

dbkr commented Nov 5, 2020

Logs being sent: yes

No logs have come in for this yet, although I'm not sure they'd be useful for this

I do see a tiny bit of stuttering when the emoji completions are displayed. How long does the UI freeze for you?

@dbkr dbkr added P1 X-Needs-Info This issue is blocked awaiting information from the reporter S-Minor Impairs non-critical functionality or suitable workarounds exist A-Composer labels Nov 5, 2020
@f0x52
Copy link
Author

f0x52 commented Nov 5, 2020

whoops forgot to send those, but yeah

according to the performance profiler, it's about 6 seconds, which seems consistent across test as well
image

@dbkr
Copy link
Member

dbkr commented Nov 5, 2020

Wow, looks like the browser is spending 6s doing layout. Is there anything notable about your account or setup that might be causing it do render huge amounts of DOM at that point?

@f0x52
Copy link
Author

f0x52 commented Nov 5, 2020

It's a rather big account (sync takes ages) but not sure if any of that would be relevant to the emoji picker?

@f0x52
Copy link
Author

f0x52 commented Nov 19, 2020

Seems it is related to the whole autocomplete UI, as it happens for /command completion as well.
Switched to a new session on develop.element.io and it's the same

@yannicka
Copy link

@f0x52 are you still experiencing the problem with the most recent versions of Element?

@SimonBrandner SimonBrandner added X-Needs-Info This issue is blocked awaiting information from the reporter A-Autocomplete A-Emoji A-Performance O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed X-Needs-Info This issue is blocked awaiting information from the reporter P1 labels Aug 29, 2021
@robintown
Copy link
Member

Closing due to lack of info

@Benjamin-L
Copy link

I'm still experiencing this on the most recent version any time the autocomplete UI is invoked. One thing that's notable is that I've experienced this behavior on multiple different devices. Two linux machines running firefox and two different macs with firefox. I haven't tested any other browsers.

@robintown robintown reopened this Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Autocomplete A-Composer A-Emoji A-Performance O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter
Projects
None yet
Development

No branches or pull requests

6 participants