Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tab completion treats search for @r to include users starting m #16477

Open
michaelkaye opened this issue Feb 18, 2021 · 4 comments
Open

tab completion treats search for @r to include users starting m #16477

michaelkaye opened this issue Feb 18, 2021 · 4 comments
Labels
A-Autocomplete P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@michaelkaye
Copy link
Contributor

Description

Typing @r<tab> in a channel does not tab complete to users with "r" at the start of their name.

I'm fairly sure this used to just show users which matched 'r'

Steps to reproduce

Type @r<tab> in the message box:

tab-complete

Get these options:

suggestion

Describe how what happens differs from what you expected.

I would expect that matmaul no 'R' in display name or mxid, matthew and manu (an R in their mxID only: 'matrRix.org') are not offered as suggestions, and instead richvdh with R at the start of their name, to be among the first in the suggestions.

Beyond these first few users which are definitely wrong, the remaining users all start R or M as well - it's like the two letters are confused with each other.

Logs being sent: yes

Version information

  • Platform: web

For the web app:

  • Browser: Firefox 85.0.1
  • OS: ubuntu
  • URL: app.element.io
@michaelkaye
Copy link
Contributor Author

This is persistent across switching away from the room and back

@michaelkaye
Copy link
Contributor Author

This is present across all rooms i'm part of, and having tested all the lowercase letters of the alphabet, the only oddness is that "r" includes "m".

M does not include R though.

@t3chguy
Copy link
Member

t3chguy commented Feb 18, 2021

This is a side effect of allowing rn to match m by use of unhomoglyph https://github.com/nodeca/unhomoglyph

@michaelkaye
Copy link
Contributor Author

No objection to "m" being shown iff there's no r's to go first; but exact matches should always take precedence over fuzzy matches.

@jryans jryans added A-Autocomplete P2 S-Minor Impairs non-critical functionality or suitable workarounds exist labels Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Autocomplete P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

3 participants