Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message for "Room was previously configured to use encryption, but is no longer." is now swallowed rather than presented to the user #18463

Open
ara4n opened this issue Aug 9, 2021 · 1 comment
Labels
A-Composer A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Aug 9, 2021

Steps to reproduce

Go to an e2ee room whose m.room.encryption event has been reset and send a message. (In this instance, it hasn't deliberately been reset, but the client has got confused)

What happened?

Screenshot 2021-08-09 at 16 59 14

The relevant error ends up in the JS console however:

sendEvent of type m.room.message in !kGLhQmvYrFWnVNxhBx:matrix.org with txnId m1628524623349.189
16:57:03.366 rageshake.js?432e:65 setting pendingEvent status to encrypting in !kGLhQmvYrFWnVNxhBx:matrix.org event ID ~!kGLhQmvYrFWnVNxhBx:matrix.org:m1628524623349.189 -> undefined
16:57:03.383 rageshake.js?432e:65 Error sending event Error: Room was previously configured to use encryption, but is no longer. Perhaps the homeserver is hiding the configuration event.
    at Crypto.encryptEvent (webpack-internal:///164:2598:13)
    at MatrixClient.encryptEventIfNeeded (webpack-internal:///118:3151:24)
    at eval (webpack-internal:///118:3057:38)
consoleObj.<computed> @ rageshake.js?432e:65
16:57:03.384 rageshake.js?432e:65 setting pendingEvent status to not_sent in !kGLhQmvYrFWnVNxhBx:matrix.org event ID ~!kGLhQmvYrFWnVNxhBx:matrix.org:m1628524623349.189 -> undefined

So this is a regression where we should be showing the human-facing error to the user, but we're not any more since we redesigned the error UI a few months ago.

What did you expect?

Error should be presented to the user in the UI like we used to.

Operating system

macOS

Application version

nightly today

How did you install the app?

No response

@ara4n ara4n added the T-Defect label Aug 9, 2021
@t3chguy
Copy link
Member

t3chguy commented Aug 9, 2021

Related #17663

@germain-gg germain-gg added A-Composer A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Composer A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

No branches or pull requests

3 participants