Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting room with enter key sometimes inserts newline in message input box #18793

Open
ilmari opened this issue Aug 26, 2021 · 7 comments
Open
Labels
A-Composer A-Room-List A-Shortcuts Keyboard shortcuts A-Timeline-Search O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Defect X-Cannot-Reproduce

Comments

@ilmari
Copy link

ilmari commented Aug 26, 2021

Steps to reproduce

  1. Press Ctrl-K to filter rooms
  2. Type room name
  3. Press enter to select room

What happened?

The message input box is focused, and a newline inserted (but not always, it seems to be timing-dependent).

What did you expect?

The message input box is focused, but no text is inserted.

Operating system

Linux

Browser information

Firefox ESR 78.13.0

URL for webapp

app.element.io

Homeserver

ilmari.org

Have you submitted a rageshake?

No

@SimonBrandner SimonBrandner added A-Shortcuts Keyboard shortcuts S-Tolerable Low/no impact on users O-Uncommon Most users are unlikely to come across this or unexpected workflow A-Composer A-Room-List A-Timeline-Search labels Aug 26, 2021
@SimonBrandner
Copy link
Contributor

I don't think I am able to repro

@robintown
Copy link
Member

robintown commented Aug 26, 2021

You maybe need Use Ctrl + Enter to send a message to be enabled

@SimonBrandner
Copy link
Contributor

You maybe need Use Ctrl + Enter to send a message to be enabled

I have that enabled :P

@ilmari
Copy link
Author

ilmari commented Aug 26, 2021

You maybe need Use Ctrl + Enter to send a message to be enabled

I have that enabled :P

I haven't

@SimonBrandner
Copy link
Contributor

I still can't repro :( @ilmari, what would you say are the chances that you're holding the key for a bit too long or your device being a bit slow (searching the room-list can be expensive, afaik) with registering the key went up?

@SimonBrandner SimonBrandner added the X-Needs-Info This issue is blocked awaiting information from the reporter label Aug 27, 2021
@ilmari
Copy link
Author

ilmari commented Aug 27, 2021

How long I hold the key doesn't seem to affect it, but it happens more often when I type the name (or a short prefix of it) quickly and hit enter before the room list has finished filtering. Then, after that finishes and focus moves back to the text input field, I can see the newline appear.

The device isn't particularly slow (2.7GHz Core i7 laptop), but it's Firefox Extended Support Release (because Debian), so a quite old version (78). I can see if it happens on my similarly-specced Ubuntu laptop with Firefox 91 later.

@ilmari
Copy link
Author

ilmari commented Sep 27, 2021

I can reproduce it on Firefox 92 too, but because it's much snappier the time window is smaller (i.e. I have to hit enter much quicker after typing in the room filter box).

@robintown robintown removed the X-Needs-Info This issue is blocked awaiting information from the reporter label Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Composer A-Room-List A-Shortcuts Keyboard shortcuts A-Timeline-Search O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Defect X-Cannot-Reproduce
Projects
None yet
Development

No branches or pull requests

3 participants