Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac: End key unreliable #18916

Open
Behodar opened this issue Sep 6, 2021 · 2 comments
Open

Mac: End key unreliable #18916

Behodar opened this issue Sep 6, 2021 · 2 comments
Labels
A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Defect X-Needs-Product More input needed from the Product team

Comments

@Behodar
Copy link

Behodar commented Sep 6, 2021

Steps to reproduce

The "End" key doesn't work reliably on my machine.

  1. Open a room with a decent amount of history.
  2. Start scrolling up (such as with the scroll wheel). It appears that this bug is only triggered when you scroll up enough that it shows the "loading" spinner thingy, so keep scrolling until you see that.
  3. Press the End key on the keyboard.

What happened?

What did you expect?

I expected this to return to the latest message in the room.

What happened?

It scrolled down, but by a seemingly-random amount. I had to press End multiple times to get to the bottom.

I noticed that #3232 mentions using Ctrl-End to jump to the bottom, and this appears to work correctly (I believe that that's the standard key combination for this action on Windows). However, I'd expect a Mac app to scroll all the way to the end when I press End by itself.

Operating system

macOS 11.4

Application version

Element 1.8.2

How did you install the app?

From https://element.io/get-started

Homeserver

matrix.org

Have you submitted a rageshake?

No

@dbkr
Copy link
Member

dbkr commented Sep 6, 2021

The end key doesn't appear to do anything for me at all, regardless of whether I've seen the back-pagination spinner (page-up & page-down do the right thing though).

@dbkr
Copy link
Member

dbkr commented Sep 6, 2021

Ah, this was because home & end only work if an element in the timeline has the focus, not if the composer has the focus. This may be related to that, ie could be something else stealing the focus when the pagination spinner appears. It does looks like the composer maps home & end to start/end of line which isn't strictly correct in macOS (although lots of apps appear to do it). Perhaps we should explicitly make it so End scrolls the timeline when the composer is focused (probably ignoring Home: it's what Messages does which has similar infinite back pagination behaviour).

@dbkr dbkr added A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users X-Needs-Product More input needed from the Product team labels Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Defect X-Needs-Product More input needed from the Product team
Projects
None yet
Development

No branches or pull requests

2 participants