Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desktop notifications for invites show user IDs instead of displaynames #21022

Closed
c-cal opened this issue Feb 10, 2022 · 2 comments · Fixed by matrix-org/matrix-react-sdk#7780
Closed

Desktop notifications for invites show user IDs instead of displaynames #21022

c-cal opened this issue Feb 10, 2022 · 2 comments · Fixed by matrix-org/matrix-react-sdk#7780
Labels
A-DMs A-Invite O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@c-cal
Copy link

c-cal commented Feb 10, 2022 •
edited
Loading

Steps to reproduce

  • desktop notifications must be enabled and authorized
  • being invited by someone into a room

Outcome

What did you expect?

Show displaynames just like in the timeline

What happened instead?

image

Operating system

No response

Browser information

No response

URL for webapp

https://develop.element.io

Application version

Element version: d4a019b-react-f6565bfbc806-js-ea0eaff212a7

Homeserver

No response

Will you send logs?

No
@c-cal c-cal added the T-Defect label Feb 10, 2022
@erkinalp
Copy link
Contributor

This is not a bug, as display names are currently per-room.
matrix-org/matrix-spec-proposals#1228 might fix the underlying issue.

@SimonBrandner SimonBrandner added A-DMs A-Invite O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist labels Feb 10, 2022
@c-cal
Copy link
Author

c-cal commented Feb 10, 2022

It seems to me that the event object (matrix-js-sdk/src/models/event) is built in an "incremental" way, and that its attributes sender and target are initially not defined => not annoying for a React component with successive renderings (timeline), annoying for an immutable notification.

@c-cal c-cal mentioned this issue Feb 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-DMs A-Invite O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix desktop notifications for invites showing user IDs instead of displaynames
3 participants
@erkinalp @SimonBrandner @c-cal