Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Recently viewed" dropdown overlaps the new search experience #21847

Closed
germain-gg opened this issue Apr 19, 2022 · 8 comments · Fixed by matrix-org/matrix-react-sdk#8538
Closed
Labels
A-Breadcrumbs A-New-Search-Experience The new search dialog available in Labs good first issue Good for newcomers Help Wanted Extra attention is needed O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs

Comments

@germain-gg
Copy link
Contributor

Steps to reproduce

  1. Enable new room breadcrumbs
  2. Enable new search experience
  3. Hover over "Recently viewed"
  4. Hit "CtrlOrCommand+K"

Outcome

What did you expect?

For the "recently viewed" dropdown to be either closed, or at the very least displayed under the new search dialog

What happened instead?

It's displayed over, and looks very out of place

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

@germain-gg germain-gg added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist A-Breadcrumbs O-Uncommon Most users are unlikely to come across this or unexpected workflow good first issue Good for newcomers A-New-Search-Experience The new search dialog available in Labs labels Apr 19, 2022
@robintown
Copy link
Member

Applies to any dialog that can be opened with the keyboard, e.g. the keyboard shortcuts dialog

@yaya-usman
Copy link
Contributor

@robintown can you help reproduce the issue by demonstrating with a video or something when you're free, i don't seem to understand the original issue statement very well

@robintown
Copy link
Member

@yaya-usman This is what it looks like:

resize.mp4

@yaya-usman
Copy link
Contributor

@robintown Thanks, So how do i enable recently viewed breadcrumbs can't find it in the room settings. Also when i hit ctrl+K, it doesn't bring the keyboard shortcuts dialog like in the video but rather a search dialog.

@SimonBrandner
Copy link
Contributor

@robintown Thanks, So how do i enable recently viewed breadcrumbs can't find it in the room settings. Also when i hit ctrl+K, it doesn't bring the keyboard shortcuts dialog like in the video but rather a search dialog.

The new breadcrumbs menu is a labs feature, so you'd need to enable labs settings and then enabled it. The new search experience is also labs feature though it should be accessible as a beta option in the labs section

@yaya-usman
Copy link
Contributor

@SimonBrandner Thanks, But so far i could only find Thread and new search experience in the labs settings as in the image below, no viewed breadcrumb or is there other way of enabling it?

Capture

@SimonBrandner
Copy link
Contributor

You need to enable labs, see https://github.com/vector-im/element-web/blob/develop/docs/labs.md, I would suggest moving to https://matrix.to/#/#element-dev:matrix.org for further discussion

@yaya-usman
Copy link
Contributor

@SimonBrandner Thanks, it's now enabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Breadcrumbs A-New-Search-Experience The new search dialog available in Labs good first issue Good for newcomers Help Wanted Extra attention is needed O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants