Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Enforce labels CI check doesn't like the label being set using the PR description #22040

Closed
SimonBrandner opened this issue May 3, 2022 · 1 comment · Fixed by matrix-org/matrix-js-sdk#2449
Closed

The Enforce labels CI check doesn't like the label being set using the PR description #22040

SimonBrandner opened this issue May 3, 2022 · 1 comment · Fixed by matrix-org/matrix-js-sdk#2449
Assignees
@t3chguy
Labels
A-Developer-Experience O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Task Tasks for the team like planning
Projects
Web App Team

Comments

@SimonBrandner
Copy link
Contributor

No description provided.

@duxovni duxovni added T-Task Tasks for the team like planning A-Developer-Experience labels May 4, 2022
@SimonBrandner SimonBrandner added the S-Major Severely degrades major functionality or product features, with no satisfactory workaround label Jun 5, 2022
@SimonBrandner SimonBrandner mentioned this issue Jun 5, 2022
Merged
@SimonBrandner SimonBrandner added the O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience label Jun 5, 2022
@t3chguy
Copy link
Member

t3chguy commented Jun 5, 2022

This is because the result of a github action cannot trigger another github action, so allchange adding a label doesnt re trigger enforce labels

@t3chguy t3chguy self-assigned this Jun 10, 2022
@RiotRobot RiotRobot added this to Ready in Web App Team Jun 10, 2022
@t3chguy t3chguy moved this from Ready to In Review in Web App Team Jun 10, 2022
@t3chguy t3chguy mentioned this issue Jun 10, 2022
Merged
Web App Team automation moved this from In Review to Done Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Developer-Experience O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Task Tasks for the team like planning
Projects
No open projects
Web App Team
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use allchange action requireLabel instead of enforce labels action matrix-org/matrix-js-sdk
3 participants
@t3chguy @duxovni @SimonBrandner