Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing left padding for user mention pill when not showing avatar #22118

Closed
andybalaam opened this issue May 9, 2022 · 2 comments · Fixed by matrix-org/matrix-react-sdk#8545
Closed

Missing left padding for user mention pill when not showing avatar #22118

andybalaam opened this issue May 9, 2022 · 2 comments · Fixed by matrix-org/matrix-react-sdk#8545
Assignees
@SimonBrandner
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect X-Regression

Comments

@andybalaam
Copy link
Contributor

Steps to reproduce

  1. In Settings set "Show avatars in user and room mentions" to false
    image
  2. Go to a room where a user was mentioned

Outcome

What did you expect?

Padding on both sides of the user's name

What happened instead?

The left side of the user's name is too close to the edge of the pill

image

Operating system

Ubuntu 21.10

Browser information

Firefox 99.0

URL for webapp

https://develop.element.io

Application version

Element version: 31b4354-react-7e15bef06234-js-da69ca215b9c Olm version: 3.2.8

Homeserver

matrix.org

Will you send logs?

No
@andybalaam
Copy link
Contributor Author

Implementation note: when I manually set .mx_Pill's padding to 0.1rem 0.4em 0.1rem 0.4rem instead of the current 0.1rem 0.4em 0.1rem 0 the problem is fixed (the fixed version ends with 0.4rem instead of 0.

But, this will presumably break the appearance when the avatar is visible.

@andybalaam andybalaam added S-Tolerable Low/no impact on users O-Occasional Affects or can be seen by some users regularly or most users rarely labels May 9, 2022
@SimonBrandner SimonBrandner self-assigned this May 9, 2022
@SimonBrandner
Copy link
Contributor

Regressed by matrix-org/matrix-react-sdk#6398

@SimonBrandner SimonBrandner mentioned this issue May 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimonBrandner SimonBrandner

Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the look of pills matrix-org/matrix-react-sdk
3 participants
@andybalaam @t3chguy @SimonBrandner