Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previewing a room adds it to the 'historical' section of the roomlist #22473

Closed
Winterhuman opened this issue Jun 7, 2022 · 1 comment · Fixed by matrix-org/matrix-react-sdk#11316
Assignees
Labels
A-Peeking A-Room-List O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression

Comments

@Winterhuman
Copy link

Winterhuman commented Jun 7, 2022

Steps to reproduce

  1. Search for #archlinux:archlinux.org.
  2. Preview the room.
  3. See the Archlinux room show up in Historical upon fully loading everytime.
  4. Find another room such as #grapheneos:grapheneos.org, #CalyxOS:matrix.org, etc (most rooms are not like #archlinux:archlinux.org).
  5. Preview the room.
  6. See that none of the rooms show up in Historical.
  7. Close and open Element (full restart) and see all rooms suddenly show up in Historical as expected (or not, previewed rooms ending up in Historical doesn't feel correct in my opinion).

Outcome

What did you expect?

All previously previewed rooms either do (or don't) show up in Historical immediately upon fully loading.

What happened instead?

Some select rooms (doesn't seem to be based on Homeserver) will end up in Historical upon loading, but most other rooms don't and require restarting Element to show up.

Additional: Sometimes they'll also get stuck and require a restart to be removed (related to #18473), as well as leave notifications behind even after leaving, but, I think that's unrelated.

Operating system

Arch Linux

Application version

Element version: 1.11.3
Olm version: 3.2.12

(Originally spotted in: Element version: 1.10.13, Olm version: 3.2.8)

How did you install the app?

FlatHub

Homeserver

matrix.org

Will you send logs?

No

@robintown robintown changed the title Inconsistent room preview behaviour Previewing a room adds it to the 'historical' section of the roomlist Jun 8, 2022
@robintown
Copy link
Member

This is a regression of #10861

@robintown robintown added X-Regression S-Minor Impairs non-critical functionality or suitable workarounds exist A-Room-List A-Peeking O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Jun 8, 2022
@t3chguy t3chguy self-assigned this Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Peeking A-Room-List O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants