Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrading to v1.11.0 invalidates session #22776

Closed
3nprob opened this issue Jul 8, 2022 · 5 comments
Closed

upgrading to v1.11.0 invalidates session #22776

3nprob opened this issue Jul 8, 2022 · 5 comments
Labels

Comments

@3nprob
Copy link
Contributor

3nprob commented Jul 8, 2022

Steps to reproduce

  1. Have existing installation and signed in profile of electron-desktop v1.10.15.
  2. Install v1.11.0
  3. Start element-desktop

Outcome

What did you expect?

element-desktop starts and shows a signed-in view with rooms just as on v1.10.15.

What happened instead?

The following modal is displayed with a "Sign out" button being the only actionable:

Missing session data

Some session data, including encrypted message keys, is missing. Sign out and sign in to fix this, restoring keys from backup.

Your browser likely removed this data when running low on disk space. To help us prevent this in future, please send us logs.

element-unexplained-sign-out

Operating system

Linux (NixOS)

Application version

1.11.0

How did you install the app?

No response

Homeserver

No response

Will you send logs?

No

@3nprob 3nprob added the T-Defect label Jul 8, 2022
@3nprob
Copy link
Contributor Author

3nprob commented Jul 8, 2022

Element may have been running during a period of high disk pressure but I assume the part about "your browser may have..." should only be applicable to element-web and not element-desktop?

If that assumption is not right then this issue may not be caused by the v1.11.0 upgrade.

@t3chguy
Copy link
Member

t3chguy commented Jul 8, 2022

@3nprob Element Desktop is built on Electron which uses Chromium under the hood, so a browser is still involved even if the phrasing isn't the clearest

@3nprob
Copy link
Contributor Author

3nprob commented Jul 8, 2022

So would having disk pressure while Element Desktop is running explain why crypto keys were wiped? If so, is this documented anywhere and can anything be done about it? (I did try to look for chromium/electron references on such behavior but have not came up short)

@3nprob
Copy link
Contributor Author

3nprob commented Jul 8, 2022

Potentially related issue: #18625

No flatpak here - running unsandboxed.

This happened simultaneously on two simultaneously running instances from the same installation of Element (separate profiles so should not be a cause of conflict there) but a third one on the same host, which was not running at the time that this got triggered, was unaffected.

I have no reason to believe that this occurred due do concurrently running processes attempted to modify the same file for both of these at the same time.

@turt2live
Copy link
Member

this isn't a regression.

If your disk was nearly full then browsers, including desktop, tend to purge data we ask it to store, unhelpfully.

Considering a duplicate of one of these issues:

@turt2live turt2live closed this as not planned Won't fix, can't repro, duplicate, stale Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants