Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voice message is paused when clicking "reply" or "reply in a thread" #22911

Open
grimhilt opened this issue Jul 21, 2022 · 9 comments
Open

Voice message is paused when clicking "reply" or "reply in a thread" #22911

grimhilt opened this issue Jul 21, 2022 · 9 comments
Labels
A-Voice-Messages O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Investigation

Comments

@grimhilt
Copy link

Steps to reproduce

  1. Where are you starting? What can you see?
    Considering two voice message (A and B).
  2. What do you click?
    Playing A and clicking "reply" or "reply in a thread" button in any message's action bar

Outcome

What did you expect?

Nothing except for the reply panel to appear on top of the composer.

What happened instead?

Message A is paused, message B start (due to playback queue behavior) and the reply panel appear


Additional context

This does not happen when there is only one voice message (so no queue).
The others buttons in the action bar have no effect.

Operating system

Windows

Application version

Element version: 1.11.0 Olm version: 3.2.8

How did you install the app?

https://element.io/get-started

Homeserver

custom

Will you send logs?

No

@SimonBrandner SimonBrandner added S-Minor Impairs non-critical functionality or suitable workarounds exist A-Replies reply A-Voice-Messages A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely labels Jul 21, 2022
@SimonBrandner
Copy link
Contributor

I cannot reproduce. Can you reproduce on the latest version of Element?

@SimonBrandner SimonBrandner added X-Cannot-Reproduce O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed O-Occasional Affects or can be seen by some users regularly or most users rarely labels Jul 25, 2022
@grimhilt
Copy link
Author

grimhilt commented Jul 25, 2022

Hi, thank you for looking into this @SimonBrandner.

I was able to reproduce on Element version: 1.11.0 Olm version: 3.2.8.

Ma.video.mp4

This video has been taken on https://develop.element.io, the "test" message seems to be necessary, else I cannot reproduce.
PS: this video has no sound.

@SimonBrandner
Copy link
Contributor

Ah, can repro now - this does not happen if the user who sent the message is also trying to repro the bug

@SimonBrandner SimonBrandner added O-Occasional Affects or can be seen by some users regularly or most users rarely and removed X-Cannot-Reproduce O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Jul 25, 2022
@SimonBrandner
Copy link
Contributor

This is caused by the construction of AudioPlayerBase when rendering the reply-tile above the composer or the event-tile in the thread timeline. AudioPlayerBase's constructor() calls Playback::prepare() which then emits PlaybackState.Stopped.

Apparently, emitting PlaybackState.Stopped is necessary though I am lacking the knowledge of this area of the codebase to know why exactly. @turt2live, is there are any chance you could provide some info on how to resolve this?

@grimhilt
Copy link
Author

It seems to me it is necessary as there is a new component using this playback, it create a new "instance" and this one need to be stopped for not having both instances of this playback playing.
The behavior described above also occurs when sending the message which reply to a voice message (new "instance" for the reply Tile" ?).

@SimonBrandner
Copy link
Contributor

new "instance" for the reply Tile" ?

Yes

@grimhilt
Copy link
Author

grimhilt commented Aug 5, 2022

matrix-org/matrix-react-sdk#9069 partially fixes this issue as it excludes vm in reply of the playback system.

@germain-gg
Copy link
Contributor

Cannot reproduce anymore. Closing this issue

Screen.Recording.2022-12-12.at.10.23.38.mov

@grimhilt
Copy link
Author

grimhilt commented Jan 4, 2023

Hi @gsouquet, thank you for looking into this and sorry for the delay.
I'm still able to reproduce.
The voice message is paused when it is played and is part of a playback queue and already in the timeline. Here you are recording it, which is why you cannot reproduce it.

@germain-gg germain-gg reopened this Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Voice-Messages O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Investigation
Projects
None yet
Development

No branches or pull requests

3 participants