Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room switch time: Room list is re-mounting tiles again #23001

Open
turt2live opened this issue Aug 4, 2022 · 1 comment
Open

Room switch time: Room list is re-mounting tiles again #23001

turt2live opened this issue Aug 4, 2022 · 1 comment
Labels
A-Performance A-Room-List A-Room-View O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@turt2live
Copy link
Member

Steps to reproduce

  1. Have lots of rooms
  2. Switch rooms
  3. Notice the lag

Outcome

What did you expect?

A very fast room switch time (a key metric of ours)

What happened instead?

A not-so-fast room switch.

The full room switch took nearly 10 seconds:
image

The click took 42ms to handle:
image

with a subsequent focusin taking 130ms:
image

then viewRoom took 928ms (!!):
image

causing the task to take 1.3s overall:
image

The lag in this task is what is noticeable as "switch lag": the client appears frozen when tasks run over like this.

It also appears sentry is having issues keeping up:
image
image

Additionally, the Tooltip unmounts are taking massive amounts of time within the viewRoom scope:
image

The concerning part is that there's a few dozen of these sorts of stacks in the profile:
image

this indicates that the tiles are re-mounting when they shouldn't be. Maybe one or two, but not dozens from a single click.


Overall, we should aim to optimize out some of the concerns here.

Profile is available to team members upon request :)

Operating system

Windows 10

Application version

Nightly (2022-08-04)

How did you install the app?

The Internet

Homeserver

t2l.io

Will you send logs?

No

@turt2live turt2live added T-Defect A-Performance S-Minor Impairs non-critical functionality or suitable workarounds exist A-Room-List A-Room-View O-Occasional Affects or can be seen by some users regularly or most users rarely labels Aug 4, 2022
@bkil
Copy link

bkil commented Sep 14, 2022

Related: #21738 #14574 #4997 #125 #5920 #8623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Performance A-Room-List A-Room-View O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

2 participants