Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread deleted message pops up for a very short time on load #23003

Open
weeman1337 opened this issue Aug 5, 2022 · 2 comments
Open

Thread deleted message pops up for a very short time on load #23003

weeman1337 opened this issue Aug 5, 2022 · 2 comments
Labels
A-Storage Storage layer of the app, including IndexedDB, local storage, etc. O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Defect X-Won't-Fix

Comments

@weeman1337
Copy link
Contributor

Steps to reproduce

  1. Start a thread
  2. Delete the thread and the message
  3. Reload

Outcome

What did you expect?

Not seeing my deleted message

What happened instead?

Deleted message pops up for a short time period („Hi“ message in video)

hi

Operating system

Ubuntu 22.04 LTS

Browser information

Firefox 103.0.1

URL for webapp

https://develop.element.io/

Application version

Version von Element: 3e3f279-react-e864dbfacf01-js-3907d1c28f87 Version von Olm: 3.2.12

Homeserver

No response

Will you send logs?

No

@turt2live
Copy link
Member

I don't think this is a bug we'll be able to fix. The sync accumulator didn't have a chance to persist the redaction, so it's still using the original event.

@turt2live turt2live added X-Won't-Fix S-Tolerable Low/no impact on users O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Aug 5, 2022
@MadLittleMods
Copy link
Contributor

We can fix the sync accumulator persist better instead of every 5 minutes. Currently, this would be hard because it's one big giant JSON that takes a while to persist but we can refactor how we store things to be more managable.

This kind of edge case also causes the "Beware: edge case" explained in matrix-org/matrix-react-sdk#8354 where the history refresh can appear multiple times.

@germain-gg germain-gg added A-Storage Storage layer of the app, including IndexedDB, local storage, etc. and removed A-Threads labels Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Storage Storage layer of the app, including IndexedDB, local storage, etc. O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Defect X-Won't-Fix
Projects
None yet
Development

No branches or pull requests

4 participants