Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration manager iframe should have cache busting #23295

Open
justinbot opened this issue Sep 16, 2022 · 0 comments
Open

Integration manager iframe should have cache busting #23295

justinbot opened this issue Sep 16, 2022 · 0 comments
Labels
A-EMS Issues related to EMS A-Integrations O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Enhancement

Comments

@justinbot
Copy link

justinbot commented Sep 16, 2022

Your use case

Contents of iframes appear to be cached when the URL has not changed (the extent of this seems to vary by platform, most aggressive on Element desktop).
This can result in the integration manager frontend failing to update, or breaking entirely when a new version has been deployed.

This also impacts the sticker picker.
(While the sticker picker should handle refreshing its data on visibility events, this would occur when a new version of the sticker picker widget was deployed.)

I believe the iframe cache can be busted by adding for example a randomized string to the URL in a query parameter.

Have you considered any alternatives?

Considered if this can be done with Cache-Control headers, but these don't seem to be respected for iframes.

Additional context

For the Integrator integration manager provided by Element, this manifests as a white screen (due to built assets 404ing). This is resolved on Element Desktop by opening developer tools and checking "Disable cache", or otherwise waiting for the cache to expire.

@turt2live turt2live added S-Tolerable Low/no impact on users A-Integrations O-Uncommon Most users are unlikely to come across this or unexpected workflow A-EMS Issues related to EMS labels Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-EMS Issues related to EMS A-Integrations O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants