Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking a Matrix ID in the timeline takes the user to the home screen #23342

Closed
anoadragon453 opened this issue Sep 22, 2022 · 8 comments · Fixed by matrix-org/matrix-react-sdk#11263
Assignees
Labels
A-Matrix.to A-Pills A-User-Info O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression

Comments

@anoadragon453
Copy link
Member

Steps to reproduce

  1. Click a Matrix ID in the timeline

Outcome

What did you expect?

The user profile sidebar to appear.

What happened instead?

The user profile sidebar appeared, but with a broken back button, and unexpectedly being redirected to the Home screen.

Screencast.from.09-22-2022.05.44.49.PM.webm

In the video I click the back button twice, causing it to disappear (clicking it once does nothing).

Operating system

Arch Linux

Application version

Element version: 2022090801 Olm version: 3.2.12

How did you install the app?

The AUR

Homeserver

No response

Will you send logs?

Yes

@uhoreg
Copy link
Member

uhoreg commented Sep 23, 2022

It seems to work as expected if the MXID is a pill, but not if it is plain text

@uhoreg uhoreg added S-Minor Impairs non-critical functionality or suitable workarounds exist A-User-Info O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Sep 23, 2022
@SimonBrandner
Copy link
Contributor

This sorta makes sense to me since pill is always a member of the room but a matrix.to link does not have to be

@anoadragon453
Copy link
Member Author

anoadragon453 commented Sep 26, 2022

@SimonBrandner well, usually. Though you can copy/paste pills between rooms or craft them via devtools. In that case clicking the pill, even if the user is not in the room, results in no redirects occurring.

@uhoreg
Copy link
Member

uhoreg commented Oct 4, 2022

This issue also occurs when the MXID belongs to a user in the room.

@t3chguy
Copy link
Member

t3chguy commented Jul 13, 2023

This now takes me to matrix.to in the same tab :/

@t3chguy
Copy link
Member

t3chguy commented Jul 14, 2023

This works fine on riots.im/1.11.35 but not on develop. This seems to be related to @Johennes updating linkifyjs :/

@t3chguy
Copy link
Member

t3chguy commented Jul 14, 2023

Looks like it is due to 4.1.1

Ensure function options get called with unformatted href

@Johennes
Copy link
Contributor

Thanks for fixing this @t3chguy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Matrix.to A-Pills A-User-Info O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants