Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI to prevent PRs landing if they introduce webpack warnings #23597

Open
turt2live opened this issue Oct 25, 2022 · 3 comments
Open

CI to prevent PRs landing if they introduce webpack warnings #23597

turt2live opened this issue Oct 25, 2022 · 3 comments
Labels
A-Packaging Packaging, signing, releasing T-Task Tasks for the team like planning

Comments

@turt2live
Copy link
Member

turt2live commented Oct 25, 2022

We keep. regressing. flexbox. rules, alongside just causing needless noise in webpack output - let's write CI that prevents this.

@turt2live
Copy link
Member Author

again: matrix-org/matrix-react-sdk#10163

@germain-gg
Copy link
Contributor

germain-gg commented Feb 15, 2023

In my opinion the issue is with the tool we're using.
The CSS it fixes is totally valid and owes to be transpiled by PostCSS to an output that matches our browser support. Not to generate a warning.

This could be for two reasons in my opinion (but I have not spent the time to investigate further)

  • Using outdated package versions
  • An issue with autoprefixer

@t3chguy
Copy link
Member

t3chguy commented Oct 13, 2023

https://www.npmjs.com/package/warnings-to-errors-webpack-plugin can accomplish this but right now would fail due to compound-web introducing warnings

I agree with @germain-gg on the exact cases exemplified earlier, but also agree with Travis we should treat warnings as errors once we fix our css build path

@Johennes Johennes added A-Packaging Packaging, signing, releasing and removed A-Developer-Experience labels Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Packaging Packaging, signing, releasing T-Task Tasks for the team like planning
Projects
No open projects
Development

No branches or pull requests

5 participants