Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing thread event causes stuck notification #24069

Closed
richvdh opened this issue Dec 20, 2022 · 9 comments
Closed

Missing thread event causes stuck notification #24069

richvdh opened this issue Dec 20, 2022 · 9 comments
Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter

Comments

@richvdh
Copy link
Member

richvdh commented Dec 20, 2022

Steps to reproduce

This won't go away no matter how much I open the room, scroll around, open the threads panel, ditto:

image

Outcome

Operating system

Ubuntu 22.04

Application version

Element Nightly version: 2022121801 Olm version: 3.2.12

How did you install the app?

No response

Homeserver

No response

Will you send logs?

Yes, https://github.com/matrix-org/element-web-rageshakes/issues/18581

Discussed at https://matrix.to/#/!tCaHWuHHvOHjWyqapP:matrix.org/$NJt7bWWvJJkfg-q40xnPU4D17MOnIlR6qZcQd1fBkIM?via=matrix.org&via=element.io&via=riot.ovh

@richvdh
Copy link
Member Author

richvdh commented Dec 20, 2022

It turns out I had missed an active thread; opening it reduced the unread count from 3 to 2.

Comparing with @MadLittleMods' view of the same thread, it appears I am missing the two most recent messages in the thread.

@Me4Linux
Copy link

Me4Linux commented Dec 21, 2022

Can confirm the problem - my Client (Element: 1.11.16, Olm: 3.2.12, Debian 11) shows the notification marker stuck at "1" for my favourite room. Deleted the cache and restartet the client, but that didn't help.
My other client (1.5.11, Android) works without problems with the same room showing no unread notifications.

@weeman1337 weeman1337 added the O-Occasional Affects or can be seen by some users regularly or most users rarely label Dec 21, 2022
@weeman1337
Copy link
Contributor

Comparing with @MadLittleMods' view of the same thread, it appears I am missing the two most recent messages in the thread.

That sounds like another problem @richvdh . Can you open another issue for it?

@weeman1337 weeman1337 added the S-Major Severely degrades major functionality or product features, with no satisfactory workaround label Dec 21, 2022
@richvdh
Copy link
Member Author

richvdh commented Dec 21, 2022

Comparing with @MadLittleMods' view of the same thread, it appears I am missing the two most recent messages in the thread.

That sounds like another problem @richvdh . Can you open another issue for it?

I mean I can, but isn't it likely to be the cause of my stuck notification marker? I can retitle this one instead?

@Me4Linux
Copy link

Just received an update (to version 1.11.17), the bug is gone. Thank you :-) .

@germain-gg
Copy link
Contributor

I have a feeling that matrix-org/matrix-js-sdk#3002 will have a positive impact on this.

The stuck notifications are likely caused by the missing events in the thread, so it can't send a read receipt.
I managed to reproduce this issue once and saw that the pagination token was missing.

Have not yet figured out what caused it and how to reproduce reliably

@germain-gg germain-gg changed the title Stuck notification marker Missing thread event causes stuck notification Dec 22, 2022
@weeman1337
Copy link
Contributor

matrix-org/matrix-js-sdk#3002 got merged. Can you test again on develop @richvdh ?

@weeman1337 weeman1337 added the X-Needs-Info This issue is blocked awaiting information from the reporter label Dec 23, 2022
@richvdh
Copy link
Member Author

richvdh commented Dec 23, 2022

I can't reproduce it any more with the previous version, so 🤷‍♂️

@turt2live
Copy link
Member

Closing as presumed fixed. If this is untrue, please open a new issue with fresh reproduction steps for the QA team to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter
Projects
None yet
Development

No branches or pull requests

6 participants